caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lldb] Remove Listener::SetShadow (#97555)

Browse Source 
It's not used since https://reviews.llvm.org/D157556.
This commit is contained in:
Pavel Labath
2024-07-08 12:06:32 +02:00
committed by GitHub
parent 5ce9a86110
commit b590e9a5ae
4 changed files with 7 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/include/lldb/Utility/Listener.h
View File

@@ -94,8 +94,6 @@ public:
size_t HandleBroadcastEvent(lldb::EventSP &event_sp);
void SetShadow(bool is_shadow) { m_is_shadow = is_shadow; }
private:
// Classes that inherit from Listener can see and modify these
struct BroadcasterInfo {
@@ -132,7 +130,6 @@ private:
std::mutex m_events_mutex; // Protects m_broadcasters and m_events
std::condition_variable m_events_condition;
broadcaster_manager_collection m_broadcaster_managers;
bool m_is_shadow = false;
void BroadcasterWillDestruct(Broadcaster *);

8
lldb/source/API/SBAttachInfo.cpp
View File

@@ -266,13 +266,7 @@ SBListener SBAttachInfo::GetShadowListener() {
void SBAttachInfo::SetShadowListener(SBListener &listener) {
LLDB_INSTRUMENT_VA(this, listener);
ListenerSP listener_sp = listener.GetSP();
if (listener_sp && listener.IsValid())
listener_sp->SetShadow(true);
else
listener_sp = nullptr;
m_opaque_sp->SetShadowListener(listener_sp);
m_opaque_sp->SetShadowListener(listener.GetSP());
}
const char *SBAttachInfo::GetScriptedProcessClassName() const {

8
lldb/source/API/SBLaunchInfo.cpp
View File

@@ -402,11 +402,5 @@ SBListener SBLaunchInfo::GetShadowListener() {
void SBLaunchInfo::SetShadowListener(SBListener &listener) {
LLDB_INSTRUMENT_VA(this, listener);
ListenerSP listener_sp = listener.GetSP();
if (listener_sp && listener.IsValid())
listener_sp->SetShadow(true);
else
listener_sp = nullptr;
m_opaque_sp->SetShadowListener(listener_sp);
m_opaque_sp->SetShadowListener(listener.GetSP());
}

16
lldb/source/Utility/Listener.cpp
View File

@@ -18,22 +18,16 @@
using namespace lldb;
using namespace lldb_private;
Listener::Listener(const char *name)
: m_name(name), m_broadcasters(), m_broadcasters_mutex(), m_events(),
m_events_mutex(), m_is_shadow() {
Log *log = GetLog(LLDBLog::Object);
if (log != nullptr)
LLDB_LOGF(log, "%p Listener::Listener('%s')", static_cast<void *>(this),
m_name.c_str());
Listener::Listener(const char *name) : m_name(name) {
LLDB_LOGF(GetLog(LLDBLog::Object), "%p Listener::Listener('%s')",
static_cast<void *>(this), m_name.c_str());
}
Listener::~Listener() {
Log *log = GetLog(LLDBLog::Object);
// Don't call Clear() from here as that can cause races. See #96750.
LLDB_LOGF(log, "%p Listener::%s('%s')", static_cast<void *>(this),
__FUNCTION__, m_name.c_str());
LLDB_LOGF(GetLog(LLDBLog::Object), "%p Listener::%s('%s')",
static_cast<void *>(this), __FUNCTION__, m_name.c_str());
}
void Listener::Clear() {