caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[lld][WebAssembly] Reject shared libraries when -static/-Bstatic is used (#108263)

Browse Source 
This matches the behaviour of GNU ld and the ELF version of lld.
This commit is contained in:
Sam Clegg
2024-09-11 11:22:46 -07:00
committed by GitHub
parent 1896ee3889
commit be770edee5
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lld/test/wasm/static-error.s Normal file
View File

@@ -0,0 +1,12 @@
// RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown %s -o %t.o
// RUN: wasm-ld --experimental-pic -shared -o %t.so %t.o
// RUN: wasm-ld --experimental-pic -pie -o /dev/null %t.o %t.so
// RUN: not wasm-ld -o /dev/null -static %t.o %t.so 2>&1 | FileCheck %s
// CHECK: attempted static link of dynamic object
.global _start
_start:
.functype _start () -> ()
end_function

10
lld/wasm/Driver.cpp
View File

@@ -333,9 +333,15 @@ void LinkerDriver::addFile(StringRef path) {
return;
}
case file_magic::bitcode:
case file_magic::wasm_object:
files.push_back(createObjectFile(mbref, "", 0, inLib));
case file_magic::wasm_object: {
auto obj = createObjectFile(mbref, "", 0, inLib);
if (config->isStatic && isa<SharedFile>(obj)) {
error("attempted static link of dynamic object " + path);
break;
}
files.push_back(obj);
break;
}
case file_magic::unknown:
if (mbref.getBuffer().starts_with("#STUB")) {
files.push_back(make<StubFile>(mbref));