[clang-tidy] Avoid repeated hash lookups (NFC) (#111628)

2024-10-09 06:45:44 -07:00
parent 1ad5f315ae
commit c911b0a73c
1 changed files with 1 additions and 3 deletions
--- a/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
@@ -474,10 +474,8 @@ void ProTypeMemberInitCheck::checkMissingMemberInitializer(
  // It only includes fields that have not been fixed
  SmallPtrSet<const FieldDecl *, 16> AllFieldsToInit;
  forEachField(ClassDecl, FieldsToInit, [&](const FieldDecl *F) {
-    if (!HasRecordClassMemberSet.contains(F)) {
+    if (HasRecordClassMemberSet.insert(F).second)
      AllFieldsToInit.insert(F);
-      HasRecordClassMemberSet.insert(F);
-    }
  });
  if (FieldsToInit.empty())
    return;