[ASan][test] Enable ASan tests on SPARC (#107405)
With PR #107223 and PR #107403, ASan testing can be enabled on SPARC. This patch does so, 32-bit only on both Solaris and Linux. There is no 64-bit support even in GCC. Apart from the obvious CMake changes, this patch includes a couple of testcase adjustments necessary for SPARC: - In `asan_oob_test.cpp`, the `OOB_int` subtest needs to be disabled: it performs unaligned accesses that cannot work on a strict-alignment target like SPARC. - `asan_test.cpp` needs to disable subtests that depend on support for `__builtin_setjmp` and `__builtin_longjmp`. - `zero_page_pc.cpp` reports `0x5` as the faulting address on access to `0x4`. I don't really know why, but it's consistent between Solaris and Linux. Tested on `sparcv9-sun-solaris2.11` and `sparc64-unknown-linux-gnu`.
This commit is contained in:
@@ -244,7 +244,7 @@ if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT ANDROID)
|
||||
if(APPLE)
|
||||
darwin_filter_host_archs(ASAN_SUPPORTED_ARCH ASAN_TEST_ARCH)
|
||||
endif()
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH sparc sparcv9)
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH sparcv9)
|
||||
if(OS_NAME MATCHES "SunOS")
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH x86_64)
|
||||
endif()
|
||||
|
||||
@@ -11,6 +11,13 @@
|
||||
//===----------------------------------------------------------------------===//
|
||||
#include "asan_test_utils.h"
|
||||
|
||||
#ifdef __sparc__
|
||||
// Tests using unaligned accesses cannot work on strict-alignment targets.
|
||||
#define SKIP_ON_STRICT_ALIGNMENT(x) DISABLED_##x
|
||||
#else
|
||||
#define SKIP_ON_STRICT_ALIGNMENT(x) x
|
||||
#endif
|
||||
|
||||
NOINLINE void asan_write_sized_aligned(uint8_t *p, size_t size) {
|
||||
EXPECT_EQ(0U, ((uintptr_t)p % size));
|
||||
if (size == 1) asan_write((uint8_t*)p);
|
||||
@@ -79,7 +86,7 @@ TEST(AddressSanitizer, OOB_char) {
|
||||
OOBTest<U1>();
|
||||
}
|
||||
|
||||
TEST(AddressSanitizer, OOB_int) {
|
||||
TEST(AddressSanitizer, SKIP_ON_STRICT_ALIGNMENT(OOB_int)) {
|
||||
OOBTest<U4>();
|
||||
}
|
||||
|
||||
|
||||
@@ -631,7 +631,7 @@ NOINLINE void SigLongJmpFunc1(sigjmp_buf buf) {
|
||||
|
||||
#if !defined(__ANDROID__) && !defined(__arm__) && !defined(__aarch64__) && \
|
||||
!defined(__mips__) && !defined(__mips64) && !defined(__s390__) && \
|
||||
!defined(__riscv) && !defined(__loongarch__)
|
||||
!defined(__riscv) && !defined(__loongarch__) && !defined(__sparc__)
|
||||
NOINLINE void BuiltinLongJmpFunc1(jmp_buf buf) {
|
||||
// create three red zones for these two stack objects.
|
||||
int a;
|
||||
|
||||
@@ -36,7 +36,7 @@ set(ASAN_TEST_ARCH ${ASAN_SUPPORTED_ARCH})
|
||||
if(APPLE)
|
||||
darwin_filter_host_archs(ASAN_SUPPORTED_ARCH ASAN_TEST_ARCH)
|
||||
endif()
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH sparc sparcv9)
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH sparcv9)
|
||||
if(OS_NAME MATCHES "SunOS")
|
||||
list(REMOVE_ITEM ASAN_TEST_ARCH x86_64)
|
||||
endif()
|
||||
|
||||
@@ -19,6 +19,6 @@ int main() {
|
||||
// the compiler is free to choose the order. As a result, the address is
|
||||
// either 0x4, 0xc or 0x14. The pc is still in main() because it has not
|
||||
// actually made the call when the faulting access occurs.
|
||||
// CHECK: {{AddressSanitizer: (SEGV|access-violation).*(address|pc) 0x0*[4c]}}
|
||||
// CHECK: {{AddressSanitizer: (SEGV|access-violation).*(address|pc) 0x0*[45c]}}
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -59,7 +59,7 @@ foreach(tool ${SUPPORTED_TOOLS})
|
||||
darwin_filter_host_archs(${tool_toupper}_SUPPORTED_ARCH TEST_ARCH)
|
||||
endif()
|
||||
if(${tool} STREQUAL "asan")
|
||||
list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
|
||||
list(REMOVE_ITEM TEST_ARCH sparcv9)
|
||||
endif()
|
||||
if(OS_NAME MATCHES "SunOS" AND ${tool} STREQUAL "asan")
|
||||
list(REMOVE_ITEM TEST_ARCH x86_64)
|
||||
|
||||
@@ -51,10 +51,10 @@ foreach(arch ${UBSAN_TEST_ARCH})
|
||||
if(COMPILER_RT_HAS_ASAN AND ";${ASAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
|
||||
# TODO(wwchrome): Re-enable ubsan for asan win 64-bit when ready.
|
||||
# Disable ubsan with AddressSanitizer tests for Windows 64-bit,
|
||||
# 64-bit Solaris/x86, and SPARC.
|
||||
# 64-bit Solaris/x86 and 64-bit SPARC.
|
||||
if((NOT (OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 8)) AND
|
||||
(NOT (OS_NAME MATCHES "SunOS" AND ${arch} MATCHES x86_64)) AND
|
||||
(NOT ${arch} MATCHES sparc))
|
||||
(NOT ${arch} MATCHES sparcv9))
|
||||
add_ubsan_testsuites("AddressSanitizer" asan ${arch})
|
||||
endif()
|
||||
endif()
|
||||
|
||||
Reference in New Issue
Block a user