caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[InterleavedLoadCombine] Bail out on non-byte-sized vector element type (#90705)

Browse Source 
Vectors are always tightly packed, and elements of non-byte-sized
usually do not have a well-defined (byte) offset.

Fixes https://github.com/llvm/llvm-project/issues/90695.
This commit is contained in:
Nikita Popov
2024-05-02 09:38:09 +09:00
committed by GitHub
parent 4b75fcf0a5
commit d484c4d350
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/CodeGen/InterleavedLoadCombinePass.cpp
View File

@@ -877,6 +877,9 @@ public:
if (LI->isAtomic())
return false;
if (!DL.typeSizeEqualsStoreSize(Result.VTy->getElementType()))
return false;
// Get the base polynomial
computePolynomialFromPointer(*LI->getPointerOperand(), Offset, BasePtr, DL);

19
llvm/test/CodeGen/AArch64/interleaved-load-combine-pr90695.ll Normal file
View File

@@ -0,0 +1,19 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
; RUN: opt -S -passes=interleaved-load-combine < %s | FileCheck %s
target triple = "aarch64-unknown-windows-gnu"
; Make sure we don't crash on loads of vectors of non-byte-sized types.
define <4 x i1> @test(ptr %p) {
; CHECK-LABEL: define <4 x i1> @test(
; CHECK-SAME: ptr [[P:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[LOAD:%.*]] = load <2 x i1>, ptr [[P]], align 1
; CHECK-NEXT: [[SHUF:%.*]] = shufflevector <2 x i1> [[LOAD]], <2 x i1> zeroinitializer, <4 x i32> <i32 0, i32 1, i32 2, i32 2>
; CHECK-NEXT: ret <4 x i1> [[SHUF]]
;
entry:
%load = load <2 x i1>, ptr %p, align 1
%shuf = shufflevector <2 x i1> %load, <2 x i1> zeroinitializer, <4 x i32> <i32 0, i32 1, i32 2, i32 2>
ret <4 x i1> %shuf
}