caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NFC][IR2Vec] Increasing tolerance in approximatelyEquals() of Embedding (#145117)

Browse Source 
Increase the default tolerance for `approximatelyEquals` in IR2Vec's Embedding class from 1e-6 to 1e-4.

(Tracking issue - #141817)
This commit is contained in:
S. VenkataKeerthy
2025-07-01 12:03:37 -07:00
committed by GitHub
parent 6fafa46f8c
commit efe0deae3f
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/Analysis/IR2Vec.h
View File

@@ -117,7 +117,8 @@ public:
/// Returns true if the embedding is approximately equal to the RHS embedding
/// within the specified tolerance.
bool approximatelyEquals(const Embedding &RHS, double Tolerance = 1e-6) const;
LLVM_ABI bool approximatelyEquals(const Embedding &RHS,
double Tolerance = 1e-4) const;
void print(raw_ostream &OS) const;
};

4
llvm/unittests/Analysis/IR2VecTest.cpp
View File

@@ -154,14 +154,14 @@ TEST(EmbeddingTest, ApproximatelyEqual) {
EXPECT_TRUE(E1.approximatelyEquals(E2)); // Diff = 1e-7
Embedding E3 = {1.00002, 2.00002, 3.00002}; // Diff = 2e-5
EXPECT_FALSE(E1.approximatelyEquals(E3));
EXPECT_FALSE(E1.approximatelyEquals(E3, 1e-6));
EXPECT_TRUE(E1.approximatelyEquals(E3, 3e-5));
Embedding E_clearly_within = {1.0000005, 2.0000005, 3.0000005}; // Diff = 5e-7
EXPECT_TRUE(E1.approximatelyEquals(E_clearly_within));
Embedding E_clearly_outside = {1.00001, 2.00001, 3.00001}; // Diff = 1e-5
EXPECT_FALSE(E1.approximatelyEquals(E_clearly_outside));
EXPECT_FALSE(E1.approximatelyEquals(E_clearly_outside, 1e-6));
Embedding E4 = {1.0, 2.0, 3.5}; // Large diff
EXPECT_FALSE(E1.approximatelyEquals(E4, 0.01));