caio/clang-p2996
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "[llvm] Use llvm::sort (NFC) (#96434)"

Browse Source 
This reverts commit 05d167fc20.

Reverting the patch fixes the following under EXPENSIVE_CHECKS:

  LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir
  LLVM :: CodeGen/AMDGPU/sched-group-barrier-pre-RA.mir
  LLVM :: CodeGen/PowerPC/aix-xcoff-used-with-stringpool.ll
  LLVM :: CodeGen/PowerPC/merge-string-used-by-metadata.mir
  LLVM :: CodeGen/PowerPC/mergeable-string-pool-large.ll
  LLVM :: CodeGen/PowerPC/mergeable-string-pool-pass-only.mir
  LLVM :: CodeGen/PowerPC/mergeable-string-pool.ll
This commit is contained in:
Kazu Hirata
2024-06-25 11:18:40 -07:00
parent b9353f7f3e
commit fef144cebb
15 changed files with 48 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
View File

@@ -2231,10 +2231,11 @@ static AssignmentTrackingLowering::OverlapMap buildOverlapMapAndRecordDeclares(
// order of fragment size - there should be no duplicates.
for (auto &Pair : FragmentMap) {
SmallVector<DebugVariable, 8> &Frags = Pair.second;
llvm::sort(Frags, [](const DebugVariable &Next, const DebugVariable &Elmt) {
return Elmt.getFragmentOrDefault().SizeInBits >
Next.getFragmentOrDefault().SizeInBits;
});
std::sort(Frags.begin(), Frags.end(),
[](const DebugVariable &Next, const DebugVariable &Elmt) {
return Elmt.getFragmentOrDefault().SizeInBits >
Next.getFragmentOrDefault().SizeInBits;
});
// Check for duplicates.
assert(std::adjacent_find(Frags.begin(), Frags.end()) == Frags.end());
}

6
llvm/lib/CodeGen/MLRegAllocEvictAdvisor.cpp
View File

@@ -963,9 +963,9 @@ void extractInstructionFeatures(
// frequency vector, mapping each instruction to its associated MBB.
// Start off by sorting the segments based on the beginning slot index.
llvm::sort(LRPosInfo, [](LRStartEndInfo A, LRStartEndInfo B) {
return A.Begin < B.Begin;
});
std::sort(
LRPosInfo.begin(), LRPosInfo.end(),
[](LRStartEndInfo A, LRStartEndInfo B) { return A.Begin < B.Begin; });
size_t InstructionIndex = 0;
size_t CurrentSegmentIndex = 0;
SlotIndex CurrentIndex = LRPosInfo[0].Begin;

2
llvm/lib/DWARFLinker/Parallel/ArrayList.h
View File

@@ -82,7 +82,7 @@ public:
forEach([&](T &Item) { SortedItems.push_back(Item); });
if (SortedItems.size()) {
llvm::sort(SortedItems, Comparator);
std::sort(SortedItems.begin(), SortedItems.end(), Comparator);
size_t SortedItemIdx = 0;
forEach([&](T &Item) { Item = SortedItems[SortedItemIdx++]; });

5
llvm/lib/ExecutionEngine/Orc/Core.cpp
View File

@@ -1155,9 +1155,8 @@ void JITDylib::dump(raw_ostream &OS) {
std::vector<std::pair<SymbolStringPtr, SymbolTableEntry *>> SymbolsSorted;
for (auto &KV : Symbols)
SymbolsSorted.emplace_back(KV.first, &KV.second);
llvm::sort(SymbolsSorted, [](const auto &L, const auto &R) {
return *L.first < *R.first;
});
std::sort(SymbolsSorted.begin(), SymbolsSorted.end(),
[](const auto &L, const auto &R) { return *L.first < *R.first; });
for (auto &KV : SymbolsSorted) {
OS << " \"" << *KV.first << "\": ";

2
llvm/lib/ExecutionEngine/Orc/Debugging/DebugInfoSupport.cpp
View File

@@ -50,7 +50,7 @@ static void preserveDWARFSection(LinkGraph &G, Section &Sec) {
static SmallVector<char, 0> getSectionData(Section &Sec) {
SmallVector<char, 0> SecData;
SmallVector<Block *, 8> SecBlocks(Sec.blocks().begin(), Sec.blocks().end());
llvm::sort(SecBlocks, [](Block *LHS, Block *RHS) {
std::sort(SecBlocks.begin(), SecBlocks.end(), [](Block *LHS, Block *RHS) {
return LHS->getAddress() < RHS->getAddress();
});
// Convert back to what object file would have, one blob of section content

2
llvm/lib/ProfileData/InstrProfReader.cpp
View File

@@ -476,7 +476,7 @@ RawInstrProfReader<IntPtrT>::getTemporalProfTraces(
return TemporalProfTraces;
}
// Sort functions by their timestamps to build the trace.
llvm::sort(TemporalProfTimestamps);
std::sort(TemporalProfTimestamps.begin(), TemporalProfTimestamps.end());
TemporalProfTraceTy Trace;
if (Weight)
Trace.Weight = *Weight;

5
llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp
View File

@@ -612,7 +612,10 @@ void PipelineSolver::populateReadyList(
}
if (UseCostHeur) {
llvm::sort(ReadyList, llvm::less_second());
std::sort(ReadyList.begin(), ReadyList.end(),
[](std::pair<int, int> A, std::pair<int, int> B) {
return A.second < B.second;
});
}
assert(ReadyList.size() == CurrSU.second.size());

4
llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
View File

@@ -6886,8 +6886,8 @@ bool ARMPipelinerLoopInfo::tooMuchRegisterPressure(SwingSchedulerDAG &SSD,
++Stage) {
std::deque<SUnit *> Instrs =
SMS.getInstructions(Cycle + Stage * SMS.getInitiationInterval());
llvm::sort(Instrs,
[](SUnit *A, SUnit *B) { return A->NodeNum > B->NodeNum; });
std::sort(Instrs.begin(), Instrs.end(),
[](SUnit *A, SUnit *B) { return A->NodeNum > B->NodeNum; });
for (SUnit *SU : Instrs)
ProposedSchedule.push_back(SU);
}

2
llvm/lib/Target/NVPTX/NVVMReflect.cpp
View File

@@ -208,7 +208,7 @@ static bool runNVVMReflect(Function &F, unsigned SmVersion) {
// Removing via isInstructionTriviallyDead may add duplicates to the ToRemove
// array. Filter out the duplicates before starting to erase from parent.
llvm::sort(ToRemove);
std::sort(ToRemove.begin(), ToRemove.end());
auto NewLastIter = llvm::unique(ToRemove);
ToRemove.erase(NewLastIter, ToRemove.end());

2
llvm/lib/Target/PowerPC/PPCMergeStringPool.cpp
View File

@@ -244,7 +244,7 @@ bool PPCMergeStringPool::mergeModuleStringPool(Module &M) {
return false;
// Sort the global constants to make access more efficient.
llvm::sort(MergeableStrings, CompareConstants);
std::sort(MergeableStrings.begin(), MergeableStrings.end(), CompareConstants);
SmallVector<Constant *> ConstantsInStruct;
for (GlobalVariable *GV : MergeableStrings)

6
llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
View File

@@ -2203,7 +2203,7 @@ void CallsiteContextGraph<DerivedCCG, FuncTy, CallTy>::ContextNode::print(
// Make a copy of the computed context ids that we can sort for stability.
auto ContextIds = getContextIds();
std::vector<uint32_t> SortedIds(ContextIds.begin(), ContextIds.end());
llvm::sort(SortedIds);
std::sort(SortedIds.begin(), SortedIds.end());
for (auto Id : SortedIds)
OS << " " << Id;
OS << "\n";
@@ -2238,7 +2238,7 @@ void CallsiteContextGraph<DerivedCCG, FuncTy, CallTy>::ContextEdge::print(
<< " AllocTypes: " << getAllocTypeString(AllocTypes);
OS << " ContextIds:";
std::vector<uint32_t> SortedIds(ContextIds.begin(), ContextIds.end());
llvm::sort(SortedIds);
std::sort(SortedIds.begin(), SortedIds.end());
for (auto Id : SortedIds)
OS << " " << Id;
}
@@ -2380,7 +2380,7 @@ private:
std::string IdString = "ContextIds:";
if (ContextIds.size() < 100) {
std::vector<uint32_t> SortedIds(ContextIds.begin(), ContextIds.end());
llvm::sort(SortedIds);
std::sort(SortedIds.begin(), SortedIds.end());
for (auto Id : SortedIds)
IdString += (" " + Twine(Id)).str();
} else {

31
llvm/lib/Transforms/Utils/CodeLayout.cpp
View File

@@ -986,15 +986,16 @@ private:
}
// Sorting chains by density in the decreasing order.
llvm::sort(SortedChains, [&](const ChainT *L, const ChainT *R) {
// Place the entry point at the beginning of the order.
if (L->isEntry() != R->isEntry())
return L->isEntry();
std::sort(SortedChains.begin(), SortedChains.end(),
[&](const ChainT *L, const ChainT *R) {
// Place the entry point at the beginning of the order.
if (L->isEntry() != R->isEntry())
return L->isEntry();
// Compare by density and break ties by chain identifiers.
return std::make_tuple(-L->density(), L->Id) <
std::make_tuple(-R->density(), R->Id);
});
// Compare by density and break ties by chain identifiers.
return std::make_tuple(-L->density(), L->Id) <
std::make_tuple(-R->density(), R->Id);
});
// Collect the nodes in the order specified by their chains.
std::vector<uint64_t> Order;
@@ -1354,12 +1355,14 @@ private:
}
// Sort chains by density in the decreasing order.
llvm::sort(SortedChains, [&](const ChainT *L, const ChainT *R) {
const double DL = ChainDensity[L];
const double DR = ChainDensity[R];
// Compare by density and break ties by chain identifiers.
return std::make_tuple(-DL, L->Id) < std::make_tuple(-DR, R->Id);
});
std::sort(SortedChains.begin(), SortedChains.end(),
[&](const ChainT *L, const ChainT *R) {
const double DL = ChainDensity[L];
const double DR = ChainDensity[R];
// Compare by density and break ties by chain identifiers.
return std::make_tuple(-DL, L->Id) <
std::make_tuple(-DR, R->Id);
});
// Collect the nodes in the order specified by their chains.
std::vector<uint64_t> Order;

7
llvm/tools/llvm-jitlink/llvm-jitlink.cpp
View File

@@ -1259,9 +1259,10 @@ Error Session::FileInfo::registerMultiStubEntry(
Sym.getTargetFlags());
// Let's keep stubs ordered by ascending address.
llvm::sort(Entry, [](const MemoryRegionInfo &L, const MemoryRegionInfo &R) {
return L.getTargetAddress() < R.getTargetAddress();
});
std::sort(Entry.begin(), Entry.end(),
[](const MemoryRegionInfo &L, const MemoryRegionInfo &R) {
return L.getTargetAddress() < R.getTargetAddress();
});
return Error::success();
}

2
llvm/utils/TableGen/ARMTargetDefEmitter.cpp
View File

@@ -45,7 +45,7 @@ static void EmitARMTargetDef(RecordKeeper &RK, raw_ostream &OS) {
const auto MarchB = B->getValueAsString("MArchName");
return MarchA.compare(MarchB) < 0; // A lexographically less than B
};
llvm::sort(SortedExtensions, Alphabetical);
std::sort(SortedExtensions.begin(), SortedExtensions.end(), Alphabetical);
// The ARMProcFamilyEnum values are initialised by SubtargetFeature defs
// which set the ARMProcFamily field. We can generate the enum from these defs

3
llvm/utils/TableGen/ExegesisEmitter.cpp
View File

@@ -140,7 +140,8 @@ void ExegesisEmitter::emitPfmCountersInfo(const Record &Def,
ValidationCounter->getValueAsDef("EventType")->getName(),
getPfmCounterId(ValidationCounter->getValueAsString("Counter"))});
}
llvm::sort(ValidationCounters, EventNumberLess);
std::sort(ValidationCounters.begin(), ValidationCounters.end(),
EventNumberLess);
OS << "\nstatic const std::pair<ValidationEvent, const char*> " << Target
<< Def.getName() << "ValidationCounters[] = {\n";
for (const ValidationCounterInfo &VCI : ValidationCounters) {