6eaedbb52f
When a process gets restarted TypeSystem objects associated with it may get deleted, and any CompilerType objects holding on to a reference to that type system are a use-after-free in waiting. Because of the SBAPI, we don't have tight control over where CompilerTypes go and when they are used. This is particularly a problem in the Swift plugin, where the scratch TypeSystem can be restarted while the process is still running. The Swift plugin has a lock to prevent abuse, but where there's a lock there can be bugs. This patch changes CompilerType to store a std::weak_ptr<TypeSystem>. Most of the std::weak_ptr<TypeSystem>* uglyness is hidden by introducing a wrapper class CompilerType::WrappedTypeSystem that has a dyn_cast_or_null() method. The only sites that need to know about the weak pointer implementation detail are the ones that deal with creating TypeSystems. rdar://101505232 Differential Revision: https://reviews.llvm.org/D136650
88 lines
2.4 KiB
C++
88 lines
2.4 KiB
C++
//===-- ClangUtil.cpp -----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// A collection of helper methods and data structures for manipulating clang
|
|
// types and decls.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Plugins/ExpressionParser/Clang/ClangUtil.h"
|
|
#include "Plugins/TypeSystem/Clang/TypeSystemClang.h"
|
|
|
|
using namespace clang;
|
|
using namespace lldb_private;
|
|
|
|
bool ClangUtil::IsClangType(const CompilerType &ct) {
|
|
// Invalid types are never Clang types.
|
|
if (!ct)
|
|
return false;
|
|
|
|
if (!ct.GetTypeSystem().dyn_cast_or_null<TypeSystemClang>())
|
|
return false;
|
|
|
|
if (!ct.GetOpaqueQualType())
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
clang::Decl *ClangUtil::GetDecl(const CompilerDecl &decl) {
|
|
assert(llvm::isa<TypeSystemClang>(decl.GetTypeSystem()));
|
|
return static_cast<clang::Decl *>(decl.GetOpaqueDecl());
|
|
}
|
|
|
|
QualType ClangUtil::GetQualType(const CompilerType &ct) {
|
|
// Make sure we have a clang type before making a clang::QualType
|
|
if (!IsClangType(ct))
|
|
return QualType();
|
|
|
|
return QualType::getFromOpaquePtr(ct.GetOpaqueQualType());
|
|
}
|
|
|
|
QualType ClangUtil::GetCanonicalQualType(const CompilerType &ct) {
|
|
if (!IsClangType(ct))
|
|
return QualType();
|
|
|
|
return GetQualType(ct).getCanonicalType();
|
|
}
|
|
|
|
CompilerType ClangUtil::RemoveFastQualifiers(const CompilerType &ct) {
|
|
if (!IsClangType(ct))
|
|
return ct;
|
|
|
|
QualType qual_type(GetQualType(ct));
|
|
qual_type.removeLocalFastQualifiers();
|
|
return CompilerType(ct.GetTypeSystem(), qual_type.getAsOpaquePtr());
|
|
}
|
|
|
|
clang::TagDecl *ClangUtil::GetAsTagDecl(const CompilerType &type) {
|
|
clang::QualType qual_type = ClangUtil::GetCanonicalQualType(type);
|
|
if (qual_type.isNull())
|
|
return nullptr;
|
|
|
|
return qual_type->getAsTagDecl();
|
|
}
|
|
|
|
std::string ClangUtil::DumpDecl(const clang::Decl *d) {
|
|
if (!d)
|
|
return "nullptr";
|
|
|
|
std::string result;
|
|
llvm::raw_string_ostream stream(result);
|
|
bool deserialize = false;
|
|
d->dump(stream, deserialize);
|
|
|
|
stream.flush();
|
|
return result;
|
|
}
|
|
|
|
std::string ClangUtil::ToString(const clang::Type *t) {
|
|
return clang::QualType(t, 0).getAsString();
|
|
}
|
|
|
|
std::string ClangUtil::ToString(const CompilerType &c) {
|
|
return ClangUtil::GetQualType(c).getAsString();
|
|
}
|