Drop the thread-safe flag and make the locking strategy the responsibility of the individual log handler. Previously we got away with a non-thread safe mode because we were using unbuffered streams that rely on the underlying syscalls/OS for synchronization. With the introduction of log handlers, we can have arbitrary logic involved in writing out the logs. With this patch the log handlers can pick the most appropriate locking strategy for their particular implementation. Differential revision: https://reviews.llvm.org/D127922
101 lines
3.0 KiB
Python
101 lines
3.0 KiB
Python
"""
|
|
Test lldb logging. This test just makes sure logging doesn't crash, and produces some output.
|
|
"""
|
|
|
|
|
|
|
|
import os
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class LogTestCase(TestBase):
|
|
NO_DEBUG_INFO_TESTCASE = True
|
|
|
|
def setUp(self):
|
|
super(LogTestCase, self).setUp()
|
|
self.log_file = self.getBuildArtifact("log-file.txt")
|
|
|
|
|
|
def test_file_writing(self):
|
|
self.build()
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.expect("file " + exe,
|
|
patterns=["Current executable set to .*a.out"])
|
|
|
|
if (os.path.exists(self.log_file)):
|
|
os.remove(self.log_file)
|
|
|
|
# By default, Debugger::EnableLog() will set log options to
|
|
# PREPEND_THREAD_NAME + OPTION_THREADSAFE. We don't want the
|
|
# threadnames here, so we enable just threadsafe (-t).
|
|
self.runCmd("log enable -f '%s' lldb commands" % (self.log_file))
|
|
|
|
self.runCmd("command alias bp breakpoint")
|
|
|
|
self.runCmd("bp set -n main")
|
|
|
|
self.runCmd("bp l")
|
|
|
|
self.runCmd("log disable lldb")
|
|
|
|
self.assertTrue(os.path.isfile(self.log_file))
|
|
|
|
with open(self.log_file, 'r') as f:
|
|
log_lines = f.read()
|
|
os.remove(self.log_file)
|
|
|
|
self.assertGreater(
|
|
len(log_lines),
|
|
0,
|
|
"Something was written to the log file.")
|
|
|
|
# Check that lldb truncates its log files
|
|
def test_log_truncate(self):
|
|
# put something in our log file
|
|
with open(self.log_file, "w") as f:
|
|
for i in range(1, 1000):
|
|
f.write("bacon\n")
|
|
|
|
self.runCmd("log enable -f '%s' lldb commands" % self.log_file)
|
|
self.runCmd("help log")
|
|
self.runCmd("log disable lldb")
|
|
|
|
self.assertTrue(os.path.isfile(self.log_file))
|
|
with open(self.log_file, "r") as f:
|
|
contents = f.read()
|
|
|
|
# check that it got removed
|
|
self.assertEquals(contents.find("bacon"), -1)
|
|
|
|
# Check that lldb can append to a log file
|
|
def test_log_append(self):
|
|
# put something in our log file
|
|
with open(self.log_file, "w") as f:
|
|
f.write("bacon\n")
|
|
|
|
self.runCmd( "log enable -a -f '%s' lldb commands" % self.log_file)
|
|
self.runCmd("help log")
|
|
self.runCmd("log disable lldb")
|
|
|
|
self.assertTrue(os.path.isfile(self.log_file))
|
|
with open(self.log_file, 'r') as f:
|
|
contents = f.read()
|
|
|
|
# check that it is still there
|
|
self.assertEquals(contents.find("bacon"), 0)
|
|
|
|
# Enable all log options and check that nothing crashes.
|
|
@skipIfWindows
|
|
def test_all_log_options(self):
|
|
if (os.path.exists(self.log_file)):
|
|
os.remove(self.log_file)
|
|
|
|
self.runCmd("log enable -v -s -T -p -n -S -F -f '%s' lldb commands" % self.log_file)
|
|
self.runCmd("help log")
|
|
self.runCmd("log disable lldb")
|
|
|
|
self.assertTrue(os.path.isfile(self.log_file))
|