5e50dd048e
This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
140 lines
5.1 KiB
C++
140 lines
5.1 KiB
C++
//===- DialectTest.cpp - Dialect unit tests -------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/IR/Dialect.h"
|
|
#include "mlir/IR/DialectInterface.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace mlir;
|
|
using namespace mlir::detail;
|
|
|
|
namespace {
|
|
struct TestDialect : public Dialect {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDialect)
|
|
|
|
static StringRef getDialectNamespace() { return "test"; };
|
|
TestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context, TypeID::get<TestDialect>()) {}
|
|
};
|
|
struct AnotherTestDialect : public Dialect {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(AnotherTestDialect)
|
|
|
|
static StringRef getDialectNamespace() { return "test"; };
|
|
AnotherTestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context,
|
|
TypeID::get<AnotherTestDialect>()) {}
|
|
};
|
|
|
|
TEST(DialectDeathTest, MultipleDialectsWithSameNamespace) {
|
|
MLIRContext context;
|
|
|
|
// Registering a dialect with the same namespace twice should result in a
|
|
// failure.
|
|
context.loadDialect<TestDialect>();
|
|
ASSERT_DEATH(context.loadDialect<AnotherTestDialect>(), "");
|
|
}
|
|
|
|
struct SecondTestDialect : public Dialect {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(SecondTestDialect)
|
|
|
|
static StringRef getDialectNamespace() { return "test2"; }
|
|
SecondTestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context,
|
|
TypeID::get<SecondTestDialect>()) {}
|
|
};
|
|
|
|
struct TestDialectInterfaceBase
|
|
: public DialectInterface::Base<TestDialectInterfaceBase> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDialectInterfaceBase)
|
|
|
|
TestDialectInterfaceBase(Dialect *dialect) : Base(dialect) {}
|
|
virtual int function() const { return 42; }
|
|
};
|
|
|
|
struct TestDialectInterface : public TestDialectInterfaceBase {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDialectInterface)
|
|
|
|
using TestDialectInterfaceBase::TestDialectInterfaceBase;
|
|
int function() const final { return 56; }
|
|
};
|
|
|
|
struct SecondTestDialectInterface : public TestDialectInterfaceBase {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(SecondTestDialectInterface)
|
|
|
|
using TestDialectInterfaceBase::TestDialectInterfaceBase;
|
|
int function() const final { return 78; }
|
|
};
|
|
|
|
TEST(Dialect, DelayedInterfaceRegistration) {
|
|
DialectRegistry registry;
|
|
registry.insert<TestDialect, SecondTestDialect>();
|
|
|
|
// Delayed registration of an interface for TestDialect.
|
|
registry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
|
|
MLIRContext context(registry);
|
|
|
|
// Load the TestDialect and check that the interface got registered for it.
|
|
Dialect *testDialect = context.getOrLoadDialect<TestDialect>();
|
|
ASSERT_TRUE(testDialect != nullptr);
|
|
auto *testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
|
|
// Load the SecondTestDialect and check that the interface is not registered
|
|
// for it.
|
|
Dialect *secondTestDialect = context.getOrLoadDialect<SecondTestDialect>();
|
|
ASSERT_TRUE(secondTestDialect != nullptr);
|
|
auto *secondTestDialectInterface =
|
|
dyn_cast<SecondTestDialectInterface>(secondTestDialect);
|
|
EXPECT_TRUE(secondTestDialectInterface == nullptr);
|
|
|
|
// Use the same mechanism as for delayed registration but for an already
|
|
// loaded dialect and check that the interface is now registered.
|
|
DialectRegistry secondRegistry;
|
|
secondRegistry.insert<SecondTestDialect>();
|
|
secondRegistry.addExtension(
|
|
+[](MLIRContext *ctx, SecondTestDialect *dialect) {
|
|
dialect->addInterfaces<SecondTestDialectInterface>();
|
|
});
|
|
context.appendDialectRegistry(secondRegistry);
|
|
secondTestDialectInterface =
|
|
dyn_cast<SecondTestDialectInterface>(secondTestDialect);
|
|
EXPECT_TRUE(secondTestDialectInterface != nullptr);
|
|
}
|
|
|
|
TEST(Dialect, RepeatedDelayedRegistration) {
|
|
// Set up the delayed registration.
|
|
DialectRegistry registry;
|
|
registry.insert<TestDialect>();
|
|
registry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
MLIRContext context(registry);
|
|
|
|
// Load the TestDialect and check that the interface got registered for it.
|
|
Dialect *testDialect = context.getOrLoadDialect<TestDialect>();
|
|
ASSERT_TRUE(testDialect != nullptr);
|
|
auto *testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
|
|
// Try adding the same dialect interface again and check that we don't crash
|
|
// on repeated interface registration.
|
|
DialectRegistry secondRegistry;
|
|
secondRegistry.insert<TestDialect>();
|
|
secondRegistry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
context.appendDialectRegistry(secondRegistry);
|
|
testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
}
|
|
|
|
} // namespace
|