90ec6dff86
Currently, opaque pointers are supported in two forms: The -force-opaque-pointers mode, where all pointers are opaque and typed pointers do not exist. And as a simple ptr type that can coexist with typed pointers. This patch removes support for the mixed mode. You either get typed pointers, or you get opaque pointers, but not both. In the (current) default mode, using ptr is forbidden. In -opaque-pointers mode, all pointers are opaque. The motivation here is that the mixed mode introduces additional issues that don't exist in fully opaque mode. D105155 is an example of a design problem. Looking at D109259, it would probably need additional work to support mixed mode (e.g. to generate GEPs for typed base but opaque result). Mixed mode will also end up inserting many casts between i8* and ptr, which would require significant additional work to consistently avoid. I don't think the mixed mode is particularly valuable, as it doesn't align with our end goal. The only thing I've found it to be moderately useful for is adding some opaque pointer tests in between typed pointer tests, but I think we can live without that. Differential Revision: https://reviews.llvm.org/D109290
245 lines
8.3 KiB
LLVM
245 lines
8.3 KiB
LLVM
; RUN: llc < %s -asm-verbose=false -wasm-disable-explicit-locals -wasm-keep-registers -enable-emscripten-cxx-exceptions | FileCheck %s --check-prefixes=CHECK,TYPED
|
|
; RUN: llc < %s -asm-verbose=false -wasm-disable-explicit-locals -wasm-keep-registers -enable-emscripten-cxx-exceptions -opaque-pointers | FileCheck %s --check-prefixes=CHECK,OPAQUE
|
|
|
|
; Test that function pointer casts are replaced with wrappers.
|
|
|
|
; The TYPED and OPAQUE prefixes only differ in function ordering.
|
|
|
|
target triple = "wasm32-unknown-unknown"
|
|
|
|
define void @has_i32_arg(i32) {
|
|
entry:
|
|
ret void
|
|
}
|
|
|
|
declare void @has_struct_arg({i32})
|
|
declare i32 @has_i32_ret()
|
|
declare void @vararg(...)
|
|
declare void @plain(i32)
|
|
|
|
declare void @foo0()
|
|
declare void @foo1()
|
|
declare void @foo2()
|
|
declare void @foo3()
|
|
|
|
; CHECK-LABEL: test:
|
|
; TYPED: call .Lhas_i32_arg_bitcast.2{{$}}
|
|
; TYPED-NEXT: call .Lhas_i32_arg_bitcast.2{{$}}
|
|
; OPAQUE: call .Lhas_i32_arg_bitcast{{$}}
|
|
; OPAQUE-NEXT: call .Lhas_i32_arg_bitcast{{$}}
|
|
; CHECK-NEXT: call .Lhas_i32_ret_bitcast{{$}}
|
|
; CHECK-NEXT: call $drop=, has_i32_ret
|
|
; CHECK-NEXT: i32.const $push[[L0:[0-9]+]]=, 0
|
|
; CHECK-NEXT: call .Lfoo0_bitcast, $pop[[L0]]{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L1:[0-9]+]]=, 0
|
|
; CHECK-NEXT: call .Lfoo0_bitcast, $pop[[L1]]{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L2:[0-9]+]]=, 0
|
|
; CHECK-NEXT: call .Lfoo0_bitcast, $pop[[L2]]{{$}}
|
|
; CHECK-NEXT: call foo0
|
|
; CHECK-NEXT: call $drop=, .Lfoo1_bitcast{{$}}
|
|
; CHECK-NEXT: call foo2{{$}}
|
|
; CHECK-NEXT: call foo1{{$}}
|
|
; CHECK-NEXT: call foo3{{$}}
|
|
; CHECK-NEXT: end_function
|
|
define void @test() {
|
|
entry:
|
|
call void bitcast (void (i32)* @has_i32_arg to void ()*)()
|
|
call void bitcast (void (i32)* @has_i32_arg to void ()*)()
|
|
call void bitcast (i32 ()* @has_i32_ret to void ()*)()
|
|
call i32 bitcast (i32 ()* @has_i32_ret to i32 ()*)()
|
|
call void bitcast (void ()* @foo0 to void (i32)*)(i32 0)
|
|
%p = bitcast void ()* @foo0 to void (i32)*
|
|
call void %p(i32 0)
|
|
%q = bitcast void ()* @foo0 to void (i32)*
|
|
call void %q(i32 0)
|
|
%r = bitcast void (i32)* %q to void ()*
|
|
call void %r()
|
|
%t = call i32 bitcast (void ()* @foo1 to i32 ()*)()
|
|
call void bitcast (void ()* @foo2 to void ()*)()
|
|
call void @foo1()
|
|
call void @foo3()
|
|
|
|
ret void
|
|
}
|
|
|
|
; Calling aliases should also generate a wrapper
|
|
|
|
@alias_i32_arg = weak hidden alias void (i32), void (i32)* @has_i32_arg
|
|
|
|
; CHECK-LABEL: test_alias:
|
|
; TYPED: call .Lhas_i32_arg_bitcast.2
|
|
; OPAQUE: call .Lhas_i32_arg_bitcast
|
|
define void @test_alias() {
|
|
entry:
|
|
call void bitcast (void (i32)* @alias_i32_arg to void ()*)()
|
|
ret void
|
|
}
|
|
|
|
|
|
; CHECK-LABEL: test_structs:
|
|
; TYPED: call .Lhas_i32_arg_bitcast.1, $pop{{[0-9]+}}, $pop{{[0-9]+$}}
|
|
; TYPED: call .Lhas_i32_arg_bitcast, $0, $pop2
|
|
; OPAQUE: call .Lhas_i32_arg_bitcast.2, $pop{{[0-9]+}}, $pop{{[0-9]+$}}
|
|
; OPAQUE: call .Lhas_i32_arg_bitcast.1, $0, $pop2
|
|
; CHECK: call .Lhas_struct_arg_bitcast{{$}}
|
|
define void @test_structs() {
|
|
entry:
|
|
call void bitcast (void (i32)* @has_i32_arg to void (i32, {i32})*)(i32 5, {i32} {i32 6})
|
|
call {i32, i64} bitcast (void (i32)* @has_i32_arg to {i32, i64} (i32)*)(i32 7)
|
|
call void bitcast (void ({i32})* @has_struct_arg to void ()*)()
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: test_structs_unhandled:
|
|
; CHECK: call has_struct_arg, $pop{{[0-9]+$}}
|
|
; CHECK: call has_struct_arg, $pop{{[0-9]+$}}
|
|
; CHECK: call has_i32_ret, $pop{{[0-9]+$}}
|
|
define void @test_structs_unhandled() {
|
|
entry:
|
|
call void @has_struct_arg({i32} {i32 3})
|
|
call void bitcast (void ({i32})* @has_struct_arg to void ({i64})*)({i64} {i64 4})
|
|
call {i32, i32} bitcast (i32 ()* @has_i32_ret to {i32, i32} ()*)()
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: test_varargs:
|
|
; CHECK: global.set
|
|
; CHECK: i32.const $push[[L3:[0-9]+]]=, 0{{$}}
|
|
; CHECK-NEXT: call .Lvararg_bitcast, $pop[[L3]]{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L4:[0-9]+]]=, 0{{$}}
|
|
; CHECK-NEXT: i32.store 0($[[L5:[0-9]+]]), $pop[[L4]]{{$}}
|
|
; CHECK-NEXT: call .Lplain_bitcast, $[[L5]]{{$}}
|
|
define void @test_varargs() {
|
|
call void bitcast (void (...)* @vararg to void (i32)*)(i32 0)
|
|
call void (...) bitcast (void (i32)* @plain to void (...)*)(i32 0)
|
|
ret void
|
|
}
|
|
|
|
; Don't use wrappers when the value is stored in memory
|
|
|
|
@global_func = hidden local_unnamed_addr global void ()* null
|
|
|
|
; CHECK-LABEL: test_store:
|
|
; CHECK: i32.const $push[[L0:[0-9]+]]=, 0{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L1:[0-9]+]]=, has_i32_ret{{$}}
|
|
; CHECK-NEXT: i32.store global_func($pop[[L0]]), $pop[[L1]]{{$}}
|
|
define void @test_store() {
|
|
%1 = bitcast i32 ()* @has_i32_ret to void ()*
|
|
store void ()* %1, void ()** @global_func
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: test_load:
|
|
; CHECK-NEXT: .functype test_load () -> (i32){{$}}
|
|
; CHECK-NEXT: i32.const $push[[L0:[0-9]+]]=, 0{{$}}
|
|
; CHECK-NEXT: i32.load $push[[L1:[0-9]+]]=, global_func($pop[[L0]]){{$}}
|
|
; CHECK-NEXT: call_indirect $push{{[0-9]+}}=, $pop[[L1]]{{$}}
|
|
define i32 @test_load() {
|
|
%1 = load i32 ()*, i32 ()** bitcast (void ()** @global_func to i32 ()**)
|
|
%2 = call i32 %1()
|
|
ret i32 %2
|
|
}
|
|
|
|
; Don't use wrappers when the value is passed to a function call
|
|
|
|
declare void @call_func(i32 ()*)
|
|
|
|
; CHECK-LABEL: test_argument:
|
|
; CHECK: i32.const $push[[L0:[0-9]+]]=, has_i32_ret{{$}}
|
|
; CHECK-NEXT: call call_func, $pop[[L0]]{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L1:[0-9]+]]=, has_i32_arg{{$}}
|
|
; CHECK-NEXT: call call_func, $pop[[L1]]{{$}}
|
|
define void @test_argument() {
|
|
call void @call_func(i32 ()* @has_i32_ret)
|
|
call void @call_func(i32 ()* bitcast (void (i32)* @has_i32_arg to i32 ()*))
|
|
ret void
|
|
}
|
|
|
|
; Invokes should be treated like calls
|
|
|
|
; CHECK-LABEL: test_invoke:
|
|
; CHECK: i32.const $push[[L1:[0-9]+]]=, call_func{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L0:[0-9]+]]=, has_i32_ret{{$}}
|
|
; CHECK-NEXT: call invoke_vi, $pop[[L1]], $pop[[L0]]{{$}}
|
|
; CHECK: i32.const $push[[L3:[0-9]+]]=, call_func{{$}}
|
|
; CHECK-NEXT: i32.const $push[[L2:[0-9]+]]=, has_i32_arg{{$}}
|
|
; CHECK-NEXT: call invoke_vi, $pop[[L3]], $pop[[L2]]{{$}}
|
|
; TYPED: i32.const $push[[L4:[0-9]+]]=, .Lhas_i32_arg_bitcast.2{{$}}
|
|
; OPAQUE: i32.const $push[[L4:[0-9]+]]=, .Lhas_i32_arg_bitcast{{$}}
|
|
; CHECK-NEXT: call invoke_v, $pop[[L4]]{{$}}
|
|
declare i32 @personality(...)
|
|
define void @test_invoke() personality i32 (...)* @personality {
|
|
entry:
|
|
invoke void @call_func(i32 ()* @has_i32_ret)
|
|
to label %cont unwind label %lpad
|
|
|
|
cont:
|
|
invoke void @call_func(i32 ()* bitcast (void (i32)* @has_i32_arg to i32 ()*))
|
|
to label %cont2 unwind label %lpad
|
|
|
|
cont2:
|
|
invoke void bitcast (void (i32)* @has_i32_arg to void ()*)()
|
|
to label %end unwind label %lpad
|
|
|
|
lpad:
|
|
%0 = landingpad { i8*, i32 }
|
|
catch i8* null
|
|
br label %end
|
|
|
|
end:
|
|
ret void
|
|
}
|
|
|
|
; TYPED-LABEL: .Lhas_i32_arg_bitcast:
|
|
; TYPED-NEXT: .functype .Lhas_i32_arg_bitcast (i32, i32) -> ()
|
|
; TYPED-NEXT: call has_i32_arg, $1{{$}}
|
|
; TYPED-NEXT: end_function
|
|
|
|
; TYPED-LABEL: .Lhas_i32_arg_bitcast.1:
|
|
; TYPED-NEXT: .functype .Lhas_i32_arg_bitcast.1 (i32, i32) -> ()
|
|
; TYPED-NEXT: call has_i32_arg, $0{{$}}
|
|
; TYPED-NEXT: end_function
|
|
|
|
; TYPED-LABEL: .Lhas_i32_arg_bitcast.2:
|
|
; TYPED-NEXT: .functype .Lhas_i32_arg_bitcast.2 () -> ()
|
|
; TYPED-NEXT: call has_i32_arg, $0{{$}}
|
|
; TYPED-NEXT: end_function
|
|
|
|
; OPAQUE-LABEL: .Lhas_i32_arg_bitcast:
|
|
; OPAQUE-NEXT: .functype .Lhas_i32_arg_bitcast () -> ()
|
|
; OPAQUE-NEXT: call has_i32_arg, $0{{$}}
|
|
; OPAQUE-NEXT: end_function
|
|
|
|
; OPAQUE-LABEL: .Lhas_i32_arg_bitcast.1:
|
|
; OPAQUE-NEXT: .functype .Lhas_i32_arg_bitcast.1 (i32, i32) -> ()
|
|
; OPAQUE-NEXT: call has_i32_arg, $1{{$}}
|
|
; OPAQUE-NEXT: end_function
|
|
|
|
; OPAQUE-LABEL: .Lhas_i32_arg_bitcast.2:
|
|
; OPAQUE-NEXT: .functype .Lhas_i32_arg_bitcast.2 (i32, i32) -> ()
|
|
; OPAQUE-NEXT: call has_i32_arg, $0{{$}}
|
|
; OPAQUE-NEXT: end_function
|
|
|
|
; CHECK-LABEL: .Lhas_i32_ret_bitcast:
|
|
; CHECK: call $drop=, has_i32_ret{{$}}
|
|
; CHECK-NEXT: end_function
|
|
|
|
; CHECK-LABEL: .Lvararg_bitcast:
|
|
; CHECK: call vararg, $1{{$}}
|
|
; CHECK: end_function
|
|
|
|
; CHECK-LABEL: .Lplain_bitcast:
|
|
; CHECK: call plain, $1{{$}}
|
|
; CHECK: end_function
|
|
|
|
; CHECK-LABEL: .Lfoo0_bitcast:
|
|
; CHECK-NEXT: .functype .Lfoo0_bitcast (i32) -> ()
|
|
; CHECK-NEXT: call foo0{{$}}
|
|
; CHECK-NEXT: end_function
|
|
|
|
; CHECK-LABEL: .Lfoo1_bitcast:
|
|
; CHECK-NEXT: .functype .Lfoo1_bitcast () -> (i32)
|
|
; CHECK-NEXT: call foo1{{$}}
|
|
; CHECK-NEXT: local.copy $push0=, $0
|
|
; CHECK-NEXT: end_function
|