3924877932
In the textual format, `noduplicates` means no COMDAT/section group deduplication is performed. Therefore, if both sets of sections are retained, and they happen to define strong external symbols with the same names, there will be a duplicate definition linker error. In PE/COFF, the selection kind lowers to `IMAGE_COMDAT_SELECT_NODUPLICATES`. The name describes the corollary instead of the immediate semantics. The name can cause confusion to other binary formats (ELF, wasm) which have implemented/ want to implement the "no deduplication" selection kind. Rename it to be clearer. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D106319
20 lines
465 B
LLVM
20 lines
465 B
LLVM
; Checks that comdat with nodeduplicate kind is lowered to a zero-flag ELF
|
|
; section group.
|
|
; RUN: llc < %s -mtriple=x86_64-unknown-linux | FileCheck %s
|
|
|
|
; CHECK: .section .text.f1,"axG",@progbits,f1{{$}}
|
|
; CHECK: .section .text.f2,"axG",@progbits,f1{{$}}
|
|
; CHECK: .section .bss.g1,"aGw",@nobits,f1{{$}}
|
|
|
|
$f1 = comdat nodeduplicate
|
|
|
|
define void @f1() comdat {
|
|
unreachable
|
|
}
|
|
|
|
define hidden void @f2() comdat($f1) {
|
|
unreachable
|
|
}
|
|
|
|
@g1 = global i32 0, comdat($f1)
|