Nikita Popov 9f45c5e1a6 [InstCombine] Fix infinite loop in select equivalence fold (#84036) ...

When replacing with a non-constant, it's possible that the result of the
simplification is actually more complicated than the original, and may
result in an infinite combine loop.

Mitigate the issue by requiring that either the replacement or
simplification result is constant, which should ensure that it's
simpler. While this check is crude, it does not appear to cause
optimization regressions in real-world code in practice.

Fixes https://github.com/llvm/llvm-project/issues/83127.

2024-03-06 09:33:51 +01:00

150 KiB

Raw Blame History

View Raw