fb1be9b33c
This PR introduces a step after instruction selection where instructions can be traversed from the perspective of their validity from the specification point of view. The PR adds also a way to correct load/store when there is a type mismatch contradicting the specification -- an additional bitcast is inserted to keep types consistent. Correspondent test cases are added and existing test cases are corrected. This PR helps to successfully validate with the `spirv-val` tool (https://github.com/KhronosGroup/SPIRV-Tools) some output that previously led to validation errors and crashes of back translation from SPIRV to LLVM IR from the side of SPIRV Translator project (https://github.com/KhronosGroup/SPIRV-LLVM-Translator). The added step of bringing instructions to required by the specification type correspondence can be (should be and will be) extended beyond load/store instructions to ensure validity rules of other SPIRV instructions related to type inference.
32 lines
1.1 KiB
LLVM
32 lines
1.1 KiB
LLVM
; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
|
|
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
|
|
|
|
; CHECK-DAG: %[[#TYLONG:]] = OpTypeInt 32 0
|
|
; CHECK-DAG: %[[#TYLONGPTR:]] = OpTypePointer Function %[[#TYLONG]]
|
|
; CHECK-DAG: %[[#TYSTRUCT:]] = OpTypeStruct %[[#TYLONG]]
|
|
; CHECK-DAG: %[[#CONST:]] = OpConstant %[[#TYLONG]] 3
|
|
; CHECK-DAG: %[[#TYSTRUCTPTR:]] = OpTypePointer Function %[[#TYSTRUCT]]
|
|
; CHECK: OpFunction
|
|
; CHECK: %[[#ARGPTR1:]] = OpFunctionParameter %[[#TYLONGPTR]]
|
|
; CHECK: OpStore %[[#ARGPTR1]] %[[#CONST:]]
|
|
; CHECK: OpFunction
|
|
; CHECK: %[[#OBJ:]] = OpFunctionParameter %[[#TYSTRUCT]]
|
|
; CHECK: %[[#ARGPTR2:]] = OpFunctionParameter %[[#TYLONGPTR]]
|
|
; CHECK: %[[#PTRTOSTRUCT:]] = OpBitcast %[[#TYSTRUCTPTR]] %[[#ARGPTR2]]
|
|
; CHECK: OpStore %[[#PTRTOSTRUCT]] %[[#OBJ]]
|
|
|
|
%struct.S = type { i32 }
|
|
%struct.__wrapper_class = type { [7 x %struct.S] }
|
|
|
|
define spir_kernel void @foo(%struct.S %arg, ptr %ptr) {
|
|
entry:
|
|
store %struct.S %arg, ptr %ptr
|
|
ret void
|
|
}
|
|
|
|
define spir_kernel void @bar(ptr %ptr) {
|
|
entry:
|
|
store i32 3, ptr %ptr
|
|
ret void
|
|
}
|