Kevin Frei 6566ffdf8a Clean up the GSym error aggregation code, and pass the aggregator by reference (#89688) ...

There was a problem with `llvm-gsymutil`s error aggregation code not
properly collecting aggregate errors. The was that the output aggregator
collecting errors from other threads wasn't being passed by reference,
so it was merging them into a copy of the app-wide output aggregator.

While I was at it, I added a better comment above the "Merge" code and
made it a bit more efficient, after learning more details about
`emplace` vs. `insert` or `operator[]` on `std::map`'s.

Co-authored-by: Kevin Frei <freik@meta.com>

2024-04-29 17:00:19 -07:00

30 KiB

Raw Blame History

View Raw