Donát Nagy 6fa09616da [analyzer] Use explicit call description mode in MIGChecker (#91331) ...

This commit explicitly specifies the matching mode (C library function,
any non-method function, or C++ method) for the `CallDescription`s
constructed in the checker `osx.MIG`.

The code was simplified to use a `CallDescriptionMap` instead of a raw
vector of pairs.

This change won't cause major functional changes, but isn't NFC because
it ensures that e.g. call descriptions for a non-method function won't
accidentally match a method that has the same name.

Separate commits have already performed this change in other checkers:
- easy cases: e2f1cbae45,
    6d64f8e1fe
- MallocChecker: d6d84b5d14
- iterator checkers: 06eedffe0d
- InvalidPtr checker: 024281d4d2
- apiModeling.llvm.ReturnValue: 97dd8e3c4f

... and follow-up commits will handle the remaining few checkers.

My goal is to ensure that the call description mode is always explicitly
specified and eliminate (or strongly restrict) the vague "may be either
a method or a simple function" mode that's the current default.

2024-05-08 12:38:33 +02:00

11 KiB

Raw Blame History

View Raw