da11ede57d
Random testing revealed it's possible to crash the analyzer with the
command line invocation:
clang -cc1 -analyze -analyzer-checker=nullability empty.c
where the source file, empty.c is an empty source file.
```
clang: <root>/clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:56:
void clang::ento::CheckerManager::finishedCheckerRegistration():
Assertion `Event.second.HasDispatcher && "No dispatcher registered for an event"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/
Stack dump:
0. Program arguments: clang -cc1 -analyze -analyzer-checker=nullability nullability-nocrash.c
#0 ...
...
#7 <addr> clang::ento::CheckerManager::finishedCheckerRegistration()
#8 <addr> clang::ento::CheckerManager::CheckerManager(clang::ASTContext&,
clang::AnalyzerOptions&, clang::Preprocessor const&,
llvm::ArrayRef<std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char>>>, llvm::ArrayRef<std::function<void (clang::ento::CheckerRegistry&)>>)
```
This commit removes the assertion which failed here, because it was
logically incorrect: it required that if an Event is handled by some
(enabled) checker, then there must be an **enabled** checker which can
emit that kind of Event. It should be OK to disable the event-producing
checkers but enable an event-consuming checker which has different
responsibilities in addition to handling the events.
Note that this assertion was in an `#ifndef NDEBUG` block, so this
change does not impact the non-debug builds.
Co-authored-by: Vince Bridgers <vince.a.bridgers@ericsson.com>
50 lines
1.9 KiB
C++
50 lines
1.9 KiB
C++
//===- CheckerManager.h - Static Analyzer Checker Manager -------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Defines the Static Analyzer Checker Manager.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
|
|
#include <memory>
|
|
|
|
namespace clang {
|
|
namespace ento {
|
|
|
|
CheckerManager::CheckerManager(
|
|
ASTContext &Context, AnalyzerOptions &AOptions, const Preprocessor &PP,
|
|
ArrayRef<std::string> plugins,
|
|
ArrayRef<std::function<void(CheckerRegistry &)>> checkerRegistrationFns)
|
|
: Context(&Context), LangOpts(Context.getLangOpts()), AOptions(AOptions),
|
|
PP(&PP), Diags(Context.getDiagnostics()),
|
|
RegistryData(std::make_unique<CheckerRegistryData>()) {
|
|
CheckerRegistry Registry(*RegistryData, plugins, Context.getDiagnostics(),
|
|
AOptions, checkerRegistrationFns);
|
|
Registry.initializeRegistry(*this);
|
|
Registry.initializeManager(*this);
|
|
}
|
|
|
|
CheckerManager::CheckerManager(AnalyzerOptions &AOptions,
|
|
const LangOptions &LangOpts,
|
|
DiagnosticsEngine &Diags,
|
|
ArrayRef<std::string> plugins)
|
|
: LangOpts(LangOpts), AOptions(AOptions), Diags(Diags),
|
|
RegistryData(std::make_unique<CheckerRegistryData>()) {
|
|
CheckerRegistry Registry(*RegistryData, plugins, Diags, AOptions, {});
|
|
Registry.initializeRegistry(*this);
|
|
}
|
|
|
|
CheckerManager::~CheckerManager() {
|
|
for (const auto &CheckerDtor : CheckerDtors)
|
|
CheckerDtor();
|
|
}
|
|
|
|
} // namespace ento
|
|
} // namespace clang
|