Fangrui Song 071f3b5b65 [Modules] Fix ModuleDeclState transition when module is used as a regular identifier (#71134) ...

`ModuleDeclState` is incorrectly changed to `NamedModuleImplementation`
for `struct module {}; void foo(module a);`. This is mostly benign but
leads to a spurious warning after #69555.

A real world example is:
```
// pybind11.h
class module_ { ... };
using module = module_;

// tensorflow
void DefineMetricsModule(pybind11::module main_module);
// `module main_module);` incorrectly changes `ModuleDeclState` to `NamedModuleImplementation`

#include <algorithm> // spurious warning
```

2023-11-02 22:13:08 -07:00

2.4 KiB

Raw Blame History

View Raw