2ac2e9a5b6
When a function argument is annotated with the `llvm.byval` attribute, [LLVM expects](https://llvm.org/docs/LangRef.html#parameter-attributes) the function argument type to be an `llvm.ptr`. For example: ``` func.func (%args0 : llvm.ptr {llvm.byval = !llvm.struct<(i32)>} { ... } ``` Unfortunately, this makes the type conversion context-dependent, which is something that the type conversion infrastructure (i.e., `LLVMTypeConverter` in this particular case) doesn't support. For example, we may want to convert `MyType` to `llvm.struct<(i32)>` in general, but to an `llvm.ptr` type only when it's a function argument passed by value. To fix this problem, this PR changes the FuncToLLVM conversion logic to generate an `llvm.ptr` when the function argument has a `llvm.byval` attribute. An `llvm.load` is inserted into the function to retrieve the value expected by the argument users.
106 lines
3.6 KiB
C++
106 lines
3.6 KiB
C++
//===- TestConvertFuncOp.cpp - Test LLVM Conversion of Func FuncOp --------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TestDialect.h"
|
|
|
|
#include "mlir/Conversion/FuncToLLVM/ConvertFuncToLLVM.h"
|
|
#include "mlir/Conversion/LLVMCommon/ConversionTarget.h"
|
|
#include "mlir/Conversion/LLVMCommon/Pattern.h"
|
|
#include "mlir/Dialect/Func/IR/FuncOps.h"
|
|
#include "mlir/Dialect/LLVMIR/LLVMDialect.h"
|
|
#include "mlir/IR/PatternMatch.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
|
|
/// Test helper Conversion Pattern to directly call `convertFuncOpToLLVMFuncOp`
|
|
/// to verify this utility function includes all functionalities of conversion
|
|
struct FuncOpConversion : public ConvertOpToLLVMPattern<func::FuncOp> {
|
|
FuncOpConversion(const LLVMTypeConverter &converter)
|
|
: ConvertOpToLLVMPattern(converter) {}
|
|
|
|
LogicalResult
|
|
matchAndRewrite(func::FuncOp funcOp, OpAdaptor adaptor,
|
|
ConversionPatternRewriter &rewriter) const override {
|
|
FailureOr<LLVM::LLVMFuncOp> newFuncOp = mlir::convertFuncOpToLLVMFuncOp(
|
|
cast<FunctionOpInterface>(funcOp.getOperation()), rewriter,
|
|
*getTypeConverter());
|
|
if (failed(newFuncOp))
|
|
return rewriter.notifyMatchFailure(funcOp, "Could not convert funcop");
|
|
|
|
rewriter.eraseOp(funcOp);
|
|
return success();
|
|
}
|
|
};
|
|
|
|
struct ReturnOpConversion : public ConvertOpToLLVMPattern<func::ReturnOp> {
|
|
ReturnOpConversion(const LLVMTypeConverter &converter)
|
|
: ConvertOpToLLVMPattern(converter) {}
|
|
|
|
LogicalResult
|
|
matchAndRewrite(func::ReturnOp returnOp, OpAdaptor adaptor,
|
|
ConversionPatternRewriter &rewriter) const override {
|
|
SmallVector<Type> resTys;
|
|
if (failed(typeConverter->convertTypes(returnOp->getResultTypes(), resTys)))
|
|
return failure();
|
|
|
|
rewriter.replaceOpWithNewOp<LLVM::ReturnOp>(returnOp, resTys,
|
|
adaptor.getOperands());
|
|
return success();
|
|
}
|
|
};
|
|
|
|
static std::optional<Type>
|
|
convertSimpleATypeToStruct(test::SimpleAType simpleTy) {
|
|
MLIRContext *ctx = simpleTy.getContext();
|
|
SmallVector<Type> memberTys(2, IntegerType::get(ctx, /*width=*/8));
|
|
return LLVM::LLVMStructType::getLiteral(ctx, memberTys);
|
|
}
|
|
|
|
struct TestConvertFuncOp
|
|
: public PassWrapper<TestConvertFuncOp, OperationPass<ModuleOp>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestConvertFuncOp)
|
|
|
|
void getDependentDialects(DialectRegistry ®istry) const final {
|
|
registry.insert<LLVM::LLVMDialect>();
|
|
}
|
|
|
|
StringRef getArgument() const final { return "test-convert-func-op"; }
|
|
|
|
StringRef getDescription() const final {
|
|
return "Tests conversion of `func.func` to `llvm.func` for different "
|
|
"attributes";
|
|
}
|
|
|
|
void runOnOperation() override {
|
|
MLIRContext *ctx = &getContext();
|
|
|
|
LowerToLLVMOptions options(ctx);
|
|
// Populate type conversions.
|
|
LLVMTypeConverter typeConverter(ctx, options);
|
|
typeConverter.addConversion(convertSimpleATypeToStruct);
|
|
|
|
RewritePatternSet patterns(ctx);
|
|
patterns.add<FuncOpConversion>(typeConverter);
|
|
patterns.add<ReturnOpConversion>(typeConverter);
|
|
|
|
LLVMConversionTarget target(getContext());
|
|
if (failed(applyPartialConversion(getOperation(), target,
|
|
std::move(patterns))))
|
|
signalPassFailure();
|
|
}
|
|
};
|
|
|
|
} // namespace
|
|
|
|
namespace mlir::test {
|
|
void registerConvertFuncOpPass() { PassRegistration<TestConvertFuncOp>(); }
|
|
} // namespace mlir::test
|