3e0bf1c7a9
D25618 added a method to verify the instruction predicates for an emitted instruction, through verifyInstructionPredicates added into <Target>MCCodeEmitter::encodeInstruction. This is a very useful idea, but the implementation inside MCCodeEmitter made it only fire for object files, not assembly which most of the llvm test suite uses. This patch moves the code into the <Target>_MC::verifyInstructionPredicates method, inside the InstrInfo. The allows it to be called from other places, such as in this patch where it is called from the <Target>AsmPrinter::emitInstruction methods which should trigger for both assembly and object files. It can also be called from other places such as verifyInstruction, but that is not done here (it tends to catch errors earlier, but in reality just shows all the mir tests that have incorrect feature predicates). The interface was also simplified slightly, moving computeAvailableFeatures into the function so that it does not need to be called externally. The ARM, AMDGPU (but not R600), AVR, Mips and X86 backends all currently show errors in the test-suite, so have been disabled with FIXME comments. Recommitted with some fixes for the leftover MCII variables in release builds. Differential Revision: https://reviews.llvm.org/D129506
78 lines
2.5 KiB
C++
78 lines
2.5 KiB
C++
//===- R600MCInstLower.cpp - Lower R600 MachineInstr to an MCInst ---------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
/// \file
|
|
/// Code to lower R600 MachineInstrs to their corresponding MCInst.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
|
|
#include "AMDGPUMCInstLower.h"
|
|
#include "MCTargetDesc/R600MCTargetDesc.h"
|
|
#include "R600AsmPrinter.h"
|
|
#include "R600Subtarget.h"
|
|
#include "llvm/CodeGen/MachineOperand.h"
|
|
#include "llvm/MC/MCContext.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
|
|
class R600MCInstLower : public AMDGPUMCInstLower {
|
|
public:
|
|
R600MCInstLower(MCContext &ctx, const R600Subtarget &ST,
|
|
const AsmPrinter &AP);
|
|
|
|
/// Lower a MachineInstr to an MCInst
|
|
void lower(const MachineInstr *MI, MCInst &OutMI) const;
|
|
};
|
|
|
|
R600MCInstLower::R600MCInstLower(MCContext &Ctx, const R600Subtarget &ST,
|
|
const AsmPrinter &AP)
|
|
: AMDGPUMCInstLower(Ctx, ST, AP) {}
|
|
|
|
void R600MCInstLower::lower(const MachineInstr *MI, MCInst &OutMI) const {
|
|
OutMI.setOpcode(MI->getOpcode());
|
|
for (const MachineOperand &MO : MI->explicit_operands()) {
|
|
MCOperand MCOp;
|
|
lowerOperand(MO, MCOp);
|
|
OutMI.addOperand(MCOp);
|
|
}
|
|
}
|
|
|
|
void R600AsmPrinter::emitInstruction(const MachineInstr *MI) {
|
|
R600_MC::verifyInstructionPredicates(MI->getOpcode(),
|
|
getSubtargetInfo().getFeatureBits());
|
|
|
|
const R600Subtarget &STI = MF->getSubtarget<R600Subtarget>();
|
|
R600MCInstLower MCInstLowering(OutContext, STI, *this);
|
|
|
|
StringRef Err;
|
|
if (!STI.getInstrInfo()->verifyInstruction(*MI, Err)) {
|
|
LLVMContext &C = MI->getParent()->getParent()->getFunction().getContext();
|
|
C.emitError("Illegal instruction detected: " + Err);
|
|
MI->print(errs());
|
|
}
|
|
|
|
if (MI->isBundle()) {
|
|
const MachineBasicBlock *MBB = MI->getParent();
|
|
MachineBasicBlock::const_instr_iterator I = ++MI->getIterator();
|
|
while (I != MBB->instr_end() && I->isInsideBundle()) {
|
|
emitInstruction(&*I);
|
|
++I;
|
|
}
|
|
} else {
|
|
MCInst TmpInst;
|
|
MCInstLowering.lower(MI, TmpInst);
|
|
EmitToStreamer(*OutStreamer, TmpInst);
|
|
}
|
|
}
|
|
|
|
const MCExpr *R600AsmPrinter::lowerConstant(const Constant *CV) {
|
|
if (const MCExpr *E = lowerAddrSpaceCast(TM, CV, OutContext))
|
|
return E;
|
|
return AsmPrinter::lowerConstant(CV);
|
|
}
|