1eb9a0297c
I tried to run llvm-pdbdump on a very large (~1.5GB) PDB to try and identify show-stopping performance problems. This patch addresses the first such problem. When loading the DBI stream, before anyone has even tried to access a single record, we build an in memory map of every source file for every module. In the particular PDB I was using, this was over 85 million files. Specifically, the complexity is O(m*n) where m is the number of modules and n is the average number of source files (including headers) per module. The whole reason for doing this was so that we could have constant time access to any module and any of its source file lists. However, we can still get O(1) access to the source file list for a given module with a simple O(m) precomputation, and access to the list of modules is already O(1) anyway. So this patches reduces the O(m*n) up-front precomputation to an O(m) one, where n is ~6,500 and n*m is about 85 million in my pathological test case. Differential Revision: https://reviews.llvm.org/D32870 llvm-svn: 302205
80 lines
2.0 KiB
C++
80 lines
2.0 KiB
C++
//===- NativeExeSymbol.cpp - native impl for PDBSymbolExe -------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/NativeExeSymbol.h"
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/DbiStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/InfoStream.h"
|
|
#include "llvm/DebugInfo/PDB/Native/NativeEnumModules.h"
|
|
#include "llvm/DebugInfo/PDB/Native/PDBFile.h"
|
|
|
|
namespace llvm {
|
|
namespace pdb {
|
|
|
|
NativeExeSymbol::NativeExeSymbol(NativeSession &Session)
|
|
: NativeRawSymbol(Session), File(Session.getPDBFile()) {}
|
|
|
|
std::unique_ptr<IPDBEnumSymbols>
|
|
NativeExeSymbol::findChildren(PDB_SymType Type) const {
|
|
switch (Type) {
|
|
case PDB_SymType::Compiland: {
|
|
auto Dbi = File.getPDBDbiStream();
|
|
if (Dbi) {
|
|
const DbiModuleList &Modules = Dbi->modules();
|
|
return std::unique_ptr<IPDBEnumSymbols>(
|
|
new NativeEnumModules(Session, Modules));
|
|
}
|
|
consumeError(Dbi.takeError());
|
|
break;
|
|
}
|
|
default:
|
|
break;
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
uint32_t NativeExeSymbol::getAge() const {
|
|
auto IS = File.getPDBInfoStream();
|
|
if (IS)
|
|
return IS->getAge();
|
|
consumeError(IS.takeError());
|
|
return 0;
|
|
}
|
|
|
|
std::string NativeExeSymbol::getSymbolsFileName() const {
|
|
return File.getFilePath();
|
|
}
|
|
|
|
PDB_UniqueId NativeExeSymbol::getGuid() const {
|
|
auto IS = File.getPDBInfoStream();
|
|
if (IS)
|
|
return IS->getGuid();
|
|
consumeError(IS.takeError());
|
|
return PDB_UniqueId{{0}};
|
|
}
|
|
|
|
bool NativeExeSymbol::hasCTypes() const {
|
|
auto Dbi = File.getPDBDbiStream();
|
|
if (Dbi)
|
|
return Dbi->hasCTypes();
|
|
consumeError(Dbi.takeError());
|
|
return false;
|
|
}
|
|
|
|
bool NativeExeSymbol::hasPrivateSymbols() const {
|
|
auto Dbi = File.getPDBDbiStream();
|
|
if (Dbi)
|
|
return !Dbi->isStripped();
|
|
consumeError(Dbi.takeError());
|
|
return false;
|
|
}
|
|
|
|
} // namespace pdb
|
|
} // namespace llvm
|