ac7c8eb4de
Previously checker objects were created by raw `new` calls, which necessitated managing and calling their destructors explicitly. This commit refactors this convoluted logic by introducing `unique_ptr`s that to manage the ownership of these objects automatically. This change can be thought of as stand-alone code quality improvement; but I also have a secondary motivation that I'm planning further changes in the checker registration/initialization process (to formalize our tradition of multi-part checker) and this commit "prepares the ground" for those changes.
52 lines
2.1 KiB
C++
52 lines
2.1 KiB
C++
//===- CreateCheckerManager.cpp - Checker Manager constructor ---*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Defines the constructors and the destructor of the Static Analyzer Checker
|
|
// Manager which cannot be placed under 'Core' because they depend on the
|
|
// CheckerRegistry.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
|
|
#include <memory>
|
|
|
|
namespace clang {
|
|
namespace ento {
|
|
|
|
CheckerManager::CheckerManager(
|
|
ASTContext &Context, AnalyzerOptions &AOptions, const Preprocessor &PP,
|
|
ArrayRef<std::string> plugins,
|
|
ArrayRef<std::function<void(CheckerRegistry &)>> checkerRegistrationFns)
|
|
: Context(&Context), LangOpts(Context.getLangOpts()), AOptions(AOptions),
|
|
PP(&PP), Diags(Context.getDiagnostics()),
|
|
RegistryData(std::make_unique<CheckerRegistryData>()) {
|
|
CheckerRegistry Registry(*RegistryData, plugins, Context.getDiagnostics(),
|
|
AOptions, checkerRegistrationFns);
|
|
Registry.initializeRegistry(*this);
|
|
Registry.initializeManager(*this);
|
|
}
|
|
|
|
CheckerManager::CheckerManager(AnalyzerOptions &AOptions,
|
|
const LangOptions &LangOpts,
|
|
DiagnosticsEngine &Diags,
|
|
ArrayRef<std::string> plugins)
|
|
: LangOpts(LangOpts), AOptions(AOptions), Diags(Diags),
|
|
RegistryData(std::make_unique<CheckerRegistryData>()) {
|
|
CheckerRegistry Registry(*RegistryData, plugins, Diags, AOptions, {});
|
|
Registry.initializeRegistry(*this);
|
|
}
|
|
|
|
// This is declared here to ensure that the destructors of `CheckerBase` and
|
|
// `CheckerRegistryData` are available.
|
|
CheckerManager::~CheckerManager() = default;
|
|
|
|
} // namespace ento
|
|
} // namespace clang
|