b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
65 lines
2.2 KiB
Python
65 lines
2.2 KiB
Python
"""
|
|
Tests basic Main Thread Checker support (detecting a main-thread-only violation).
|
|
"""
|
|
|
|
import lldb
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test.decorators import *
|
|
import lldbsuite.test.lldbutil as lldbutil
|
|
from lldbsuite.test.lldbplatformutil import *
|
|
import json
|
|
|
|
|
|
class MTCSimpleTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
@skipUnlessDarwin
|
|
def test(self):
|
|
self.mtc_dylib_path = findMainThreadCheckerDylib()
|
|
if self.mtc_dylib_path == "":
|
|
self.skipTest("This test requires libMainThreadChecker.dylib")
|
|
|
|
self.build()
|
|
self.mtc_tests()
|
|
|
|
@skipIf(archs=['i386'])
|
|
def mtc_tests(self):
|
|
self.assertNotEqual(self.mtc_dylib_path, "")
|
|
|
|
# Load the test
|
|
exe = self.getBuildArtifact("a.out")
|
|
self.expect("file " + exe, patterns=["Current executable set to .*a.out"])
|
|
|
|
self.runCmd("env DYLD_INSERT_LIBRARIES=%s" % self.mtc_dylib_path)
|
|
self.runCmd("run")
|
|
|
|
process = self.dbg.GetSelectedTarget().process
|
|
thread = process.GetSelectedThread()
|
|
frame = thread.GetSelectedFrame()
|
|
|
|
view = "NSView" if lldbplatformutil.getPlatform() == "macosx" else "UIView"
|
|
|
|
self.expect("thread info",
|
|
substrs=['stop reason = -[' + view +
|
|
' superview] must be used from main thread only'])
|
|
|
|
self.expect(
|
|
"thread info -s",
|
|
substrs=[
|
|
"api_name",
|
|
"class_name",
|
|
"description",
|
|
"instrumentation_class",
|
|
"selector"
|
|
])
|
|
self.assertEqual(thread.GetStopReason(), lldb.eStopReasonInstrumentation)
|
|
output_lines = self.res.GetOutput().split('\n')
|
|
json_line = '\n'.join(output_lines[2:])
|
|
data = json.loads(json_line)
|
|
self.assertEqual(data["instrumentation_class"], "MainThreadChecker")
|
|
self.assertEqual(data["api_name"], "-[" + view + " superview]")
|
|
self.assertEqual(data["class_name"], view)
|
|
self.assertEqual(data["selector"], "superview")
|
|
self.assertEqual(data["description"], "-[" + view + " superview] must be used from main thread only")
|