0642cd768b
This patch removes all of the Set.* methods from Status. This cleanup is part of a series of patches that make it harder use the anti-pattern of keeping a long-lives Status object around and updating it while dropping any errors it contains on the floor. This patch is largely NFC, the more interesting next steps this enables is to: 1. remove Status.Clear() 2. assert that Status::operator=() never overwrites an error 3. remove Status::operator=() Note that step (2) will bring 90% of the benefits for users, and step (3) will dramatically clean up the error handling code in various places. In the end my goal is to convert all APIs that are of the form ` ResultTy DoFoo(Status& error) ` to ` llvm::Expected<ResultTy> DoFoo() ` How to read this patch? The interesting changes are in Status.h and Status.cpp, all other changes are mostly ` perl -pi -e 's/\.SetErrorString/ = Status::FromErrorString/g' $(git grep -l SetErrorString lldb/source) ` plus the occasional manual cleanup.
130 lines
3.2 KiB
C++
130 lines
3.2 KiB
C++
//===-- SBFile.cpp --------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/API/SBFile.h"
|
|
#include "lldb/API/SBError.h"
|
|
#include "lldb/Host/File.h"
|
|
#include "lldb/Utility/Instrumentation.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
SBFile::~SBFile() = default;
|
|
|
|
SBFile::SBFile(FileSP file_sp) : m_opaque_sp(file_sp) {
|
|
// We have no way to capture the incoming FileSP as the class isn't
|
|
// instrumented, so pretend that it's always null.
|
|
LLDB_INSTRUMENT_VA(this, file_sp);
|
|
}
|
|
|
|
SBFile::SBFile(const SBFile &rhs) : m_opaque_sp(rhs.m_opaque_sp) {
|
|
LLDB_INSTRUMENT_VA(this, rhs);
|
|
}
|
|
|
|
SBFile &SBFile ::operator=(const SBFile &rhs) {
|
|
LLDB_INSTRUMENT_VA(this, rhs);
|
|
|
|
if (this != &rhs)
|
|
m_opaque_sp = rhs.m_opaque_sp;
|
|
return *this;
|
|
}
|
|
|
|
SBFile::SBFile() { LLDB_INSTRUMENT_VA(this); }
|
|
|
|
SBFile::SBFile(FILE *file, bool transfer_ownership) {
|
|
LLDB_INSTRUMENT_VA(this, file, transfer_ownership);
|
|
|
|
m_opaque_sp = std::make_shared<NativeFile>(file, transfer_ownership);
|
|
}
|
|
|
|
SBFile::SBFile(int fd, const char *mode, bool transfer_owndership) {
|
|
LLDB_INSTRUMENT_VA(this, fd, mode, transfer_owndership);
|
|
|
|
auto options = File::GetOptionsFromMode(mode);
|
|
if (!options) {
|
|
llvm::consumeError(options.takeError());
|
|
return;
|
|
}
|
|
m_opaque_sp =
|
|
std::make_shared<NativeFile>(fd, options.get(), transfer_owndership);
|
|
}
|
|
|
|
SBError SBFile::Read(uint8_t *buf, size_t num_bytes, size_t *bytes_read) {
|
|
LLDB_INSTRUMENT_VA(this, buf, num_bytes, bytes_read);
|
|
|
|
SBError error;
|
|
if (!m_opaque_sp) {
|
|
error = Status::FromErrorString("invalid SBFile");
|
|
*bytes_read = 0;
|
|
} else {
|
|
Status status = m_opaque_sp->Read(buf, num_bytes);
|
|
error.SetError(status);
|
|
*bytes_read = num_bytes;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
SBError SBFile::Write(const uint8_t *buf, size_t num_bytes,
|
|
size_t *bytes_written) {
|
|
LLDB_INSTRUMENT_VA(this, buf, num_bytes, bytes_written);
|
|
|
|
SBError error;
|
|
if (!m_opaque_sp) {
|
|
error = Status::FromErrorString("invalid SBFile");
|
|
*bytes_written = 0;
|
|
} else {
|
|
Status status = m_opaque_sp->Write(buf, num_bytes);
|
|
error.SetError(status);
|
|
*bytes_written = num_bytes;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
SBError SBFile::Flush() {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
|
|
SBError error;
|
|
if (!m_opaque_sp) {
|
|
error = Status::FromErrorString("invalid SBFile");
|
|
} else {
|
|
Status status = m_opaque_sp->Flush();
|
|
error.SetError(status);
|
|
}
|
|
return error;
|
|
}
|
|
|
|
bool SBFile::IsValid() const {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
return m_opaque_sp && m_opaque_sp->IsValid();
|
|
}
|
|
|
|
SBError SBFile::Close() {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
SBError error;
|
|
if (m_opaque_sp) {
|
|
Status status = m_opaque_sp->Close();
|
|
error.SetError(status);
|
|
}
|
|
return error;
|
|
}
|
|
|
|
SBFile::operator bool() const {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
return IsValid();
|
|
}
|
|
|
|
bool SBFile::operator!() const {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
return !IsValid();
|
|
}
|
|
|
|
FileSP SBFile::GetFile() const {
|
|
LLDB_INSTRUMENT_VA(this);
|
|
return m_opaque_sp;
|
|
}
|