18ad80ea6f
In SPIR-V, the capabilities for storage and compute are separate. We have good handling of the storage side in general via MemRef type conversion and various `memref` dialect ops. Once the value was loaded properly, if the compute capability is supported directly, we don't need to emulate like the storage side with int32. However, we do need to make sure casting ops are properly inserted to chain the flow to go back to the original bitwidth. Right now that is done in the each individual pattern directly, which put lots of pressure that shouldn't be on the patterns and causes duplication and trickiness w.r.t. capability check and such. Instead, we should handle such casting within the SPIR-V conversion framework using `addSourceMaterialization`, where we can check with the target environment to make sure the corresponding compute capability is allowed and then we can materialize and SPIR-V casting op. Along the way, we can drop all the duplicated cast materialization registration in various places. Reviewed By: kuhar Differential Revision: https://reviews.llvm.org/D155118
53 lines
1.8 KiB
C++
53 lines
1.8 KiB
C++
//===- ComplexToSPIRVPass.cpp - Complex to SPIR-V Passes ------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements a pass to convert Complex dialect to SPIR-V dialect.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Conversion/ComplexToSPIRV/ComplexToSPIRVPass.h"
|
|
|
|
#include "mlir/Conversion/ComplexToSPIRV/ComplexToSPIRV.h"
|
|
#include "mlir/Dialect/SPIRV/IR/SPIRVDialect.h"
|
|
#include "mlir/Dialect/SPIRV/Transforms/SPIRVConversion.h"
|
|
|
|
namespace mlir {
|
|
#define GEN_PASS_DEF_CONVERTCOMPLEXTOSPIRVPASS
|
|
#include "mlir/Conversion/Passes.h.inc"
|
|
} // namespace mlir
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
/// A pass converting MLIR Complex operations into the SPIR-V dialect.
|
|
class ConvertComplexToSPIRVPass
|
|
: public impl::ConvertComplexToSPIRVPassBase<ConvertComplexToSPIRVPass> {
|
|
void runOnOperation() override {
|
|
MLIRContext *context = &getContext();
|
|
Operation *op = getOperation();
|
|
|
|
auto targetAttr = spirv::lookupTargetEnvOrDefault(op);
|
|
std::unique_ptr<ConversionTarget> target =
|
|
SPIRVConversionTarget::get(targetAttr);
|
|
|
|
SPIRVConversionOptions options;
|
|
SPIRVTypeConverter typeConverter(targetAttr, options);
|
|
|
|
// Use UnrealizedConversionCast as the bridge so that we don't need to pull
|
|
// in patterns for other dialects.
|
|
target->addLegalOp<UnrealizedConversionCastOp>();
|
|
|
|
RewritePatternSet patterns(context);
|
|
populateComplexToSPIRVPatterns(typeConverter, patterns);
|
|
|
|
if (failed(applyPartialConversion(op, *target, std::move(patterns))))
|
|
return signalPassFailure();
|
|
}
|
|
};
|
|
} // namespace
|