This fixes an issue where the symbols for operations that were not directly handled by the rewriting in ExternalNameConversion.cpp were not updated accurately when a FuncOp symbol was modified. Resulting in a name mismatch between the FuncOp and the operation holding a symbol to the FuncOp. This fix works by updating all of the symbols relating to a FuncOp in a module, this did not show up as an issue previously as fir::CallOps were getting specific handling and only fir::CallOps were being tested. So as the more larger case is now being handled the specific handling for fir::CallOps has been removed (but is still handled by the fix). Reviewers: clementval Differential Revision: https://reviews.llvm.org/D142918
5.3 KiB
5.3 KiB