In recent PR https://github.com/llvm/llvm-project/pull/111531 for Windows support, we enabled tests that require the `make` tool. On Windows, default install directories likely contain spaces, in this case e.g. `C:\Program Files (x86)\GnuWin32\bin\make.exe`. It's typically handled well by CMake, so that today invocations from `dotest.py` don't cause issues. However, we also have nested invocations from a number of Makefiles themselves. These still failed if the path to the `make` tool contains spaces. This patch attempts to fix the functionalities/completion test by adding quotes in the respective Makefile. If it keeps passing on the bots, we can roll out the fix to all affected tests.
11 lines
193 B
Makefile
11 lines
193 B
Makefile
CXX_SOURCES := main.cpp
|
|
USE_LIBDL := 1
|
|
|
|
a.out: lib_shared
|
|
|
|
lib_shared:
|
|
"$(MAKE)" -f $(MAKEFILE_RULES) \
|
|
DYLIB_ONLY=YES DYLIB_CXX_SOURCES=shared.cpp DYLIB_NAME=shared
|
|
|
|
include Makefile.rules
|