When both SHF_LINK_ORDER | SHF_GROUP flags are set, GNU assembler from 2.35 onwards (https://sourceware.org/PR25381 https://sourceware.org/binutils/docs/as/Section.html) parses the SHF_LINK_ORDER argument before section group name, different from us. This is unfortunate, but does not matter because the `.section` flag `o` is a niche feature only used by compiler instrumentations, not adopted by hand-written assembly, and using both flags is extremely rare. Let's just match GNU assembler. There is another benefit: we now support zero-flag section group with the SHF_LINK_ORDER flag, while previously there isn't a syntax. While here, print 'G' after 'o' to be clear that the 'G' argument is parsed after the 'o' argument. To make the diff smaller, we don't print 'G' after 'w' in the absence of 'o' for now.
42 lines
1.6 KiB
LLVM
42 lines
1.6 KiB
LLVM
; RUN: llc < %s -mtriple=x86_64 -function-sections -basic-block-sections=labels | FileCheck %s
|
|
|
|
$_Z4fooTIiET_v = comdat any
|
|
|
|
define dso_local i32 @_Z3barv() {
|
|
ret i32 0
|
|
}
|
|
;; Check we add SHF_LINK_ORDER for .llvm_bb_addr_map and link it with the corresponding .text sections.
|
|
; CHECK: .section .text._Z3barv,"ax",@progbits
|
|
; CHECK-LABEL: _Z3barv:
|
|
; CHECK-NEXT: [[BAR_BEGIN:.Lfunc_begin[0-9]+]]:
|
|
; CHECK: .section .llvm_bb_addr_map,"o",@llvm_bb_addr_map,.text._Z3barv{{$}}
|
|
; CHECK-NEXT: .byte 2 # version
|
|
; CHECK-NEXT: .byte 0 # feature
|
|
; CHECK-NEXT: .quad [[BAR_BEGIN]] # function address
|
|
|
|
|
|
define dso_local i32 @_Z3foov() {
|
|
%1 = call i32 @_Z4fooTIiET_v()
|
|
ret i32 %1
|
|
}
|
|
; CHECK: .section .text._Z3foov,"ax",@progbits
|
|
; CHECK-LABEL: _Z3foov:
|
|
; CHECK-NEXT: [[FOO_BEGIN:.Lfunc_begin[0-9]+]]:
|
|
; CHECK: .section .llvm_bb_addr_map,"o",@llvm_bb_addr_map,.text._Z3foov{{$}}
|
|
; CHECK-NEXT: .byte 2 # version
|
|
; CHECK-NEXT: .byte 0 # feature
|
|
; CHECK-NEXT: .quad [[FOO_BEGIN]] # function address
|
|
|
|
|
|
define linkonce_odr dso_local i32 @_Z4fooTIiET_v() comdat {
|
|
ret i32 0
|
|
}
|
|
;; Check we add .llvm_bb_addr_map section to a COMDAT group with the corresponding .text section if such a COMDAT exists.
|
|
; CHECK: .section .text._Z4fooTIiET_v,"axG",@progbits,_Z4fooTIiET_v,comdat
|
|
; CHECK-LABEL: _Z4fooTIiET_v:
|
|
; CHECK-NEXT: [[FOOCOMDAT_BEGIN:.Lfunc_begin[0-9]+]]:
|
|
; CHECK: .section .llvm_bb_addr_map,"oG",@llvm_bb_addr_map,.text._Z4fooTIiET_v,_Z4fooTIiET_v,comdat{{$}}
|
|
; CHECK-NEXT: .byte 2 # version
|
|
; CHECK-NEXT: .byte 0 # feature
|
|
; CHECK-NEXT: .quad [[FOOCOMDAT_BEGIN]] # function address
|