Matt Arsenault 428ae0f12e AMDGPU: Do not tail call if an inreg argument requires waterfalling (#111002) ...

If we have a divergent value passed to an outgoing inreg argument,
the call needs to be executed in a waterfall loop and thus cannot
be tail called.

The waterfall handling of arbitrary calls is broken on the selectiondag
path, so some of these cases still hit an error later.

I also noticed the argument evaluation code in isEligibleForTailCallOptimization
is not correctly accounting for implicit argument assignments. It also seems
inreg codegen is generally broken; we are assigning arguments to the reserved
private resource descriptor.

2024-10-04 00:04:02 +04:00

58 KiB

Raw Blame History

View Raw