058a7a450a
Introduce the boolean ento::shouldRegister##CHECKERNAME(const LangOptions &LO) function very similarly to ento::register##CHECKERNAME. This will force every checker to implement this function, but maybe it isn't that bad: I saw a lot of ObjC or C++ specific checkers that should probably not register themselves based on some LangOptions (mine too), but they do anyways. A big benefit of this is that all registry functions now register their checker, once it is called, registration is guaranteed. This patch is a part of a greater effort to reinvent checker registration, more info here: D54438#1315953 Differential Revision: https://reviews.llvm.org/D55424 llvm-svn: 352277
71 lines
2.3 KiB
C++
71 lines
2.3 KiB
C++
//=== FixedAddressChecker.cpp - Fixed address usage checker ----*- C++ -*--===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This files defines FixedAddressChecker, a builtin checker that checks for
|
|
// assignment of a fixed address to a pointer.
|
|
// This check corresponds to CWE-587.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class FixedAddressChecker
|
|
: public Checker< check::PreStmt<BinaryOperator> > {
|
|
mutable std::unique_ptr<BuiltinBug> BT;
|
|
|
|
public:
|
|
void checkPreStmt(const BinaryOperator *B, CheckerContext &C) const;
|
|
};
|
|
}
|
|
|
|
void FixedAddressChecker::checkPreStmt(const BinaryOperator *B,
|
|
CheckerContext &C) const {
|
|
// Using a fixed address is not portable because that address will probably
|
|
// not be valid in all environments or platforms.
|
|
|
|
if (B->getOpcode() != BO_Assign)
|
|
return;
|
|
|
|
QualType T = B->getType();
|
|
if (!T->isPointerType())
|
|
return;
|
|
|
|
SVal RV = C.getSVal(B->getRHS());
|
|
|
|
if (!RV.isConstant() || RV.isZeroConstant())
|
|
return;
|
|
|
|
if (ExplodedNode *N = C.generateNonFatalErrorNode()) {
|
|
if (!BT)
|
|
BT.reset(
|
|
new BuiltinBug(this, "Use fixed address",
|
|
"Using a fixed address is not portable because that "
|
|
"address will probably not be valid in all "
|
|
"environments or platforms."));
|
|
auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), N);
|
|
R->addRange(B->getRHS()->getSourceRange());
|
|
C.emitReport(std::move(R));
|
|
}
|
|
}
|
|
|
|
void ento::registerFixedAddressChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<FixedAddressChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterFixedAddressChecker(const LangOptions &LO) {
|
|
return true;
|
|
}
|