49a3ad21d6
This patch applies clang-tidy's bugprone-argument-comment tool to LLVM, clang and lld source trees. Here is how I created this patch: $ git clone https://github.com/llvm/llvm-project.git $ cd llvm-project $ mkdir build $ cd build $ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug \ -DLLVM_ENABLE_PROJECTS='clang;lld;clang-tools-extra' \ -DCMAKE_EXPORT_COMPILE_COMMANDS=On -DLLVM_ENABLE_LLD=On \ -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ../llvm $ ninja $ parallel clang-tidy -checks='-*,bugprone-argument-comment' \ -config='{CheckOptions: [{key: StrictMode, value: 1}]}' -fix \ ::: ../llvm/lib/**/*.{cpp,h} ../clang/lib/**/*.{cpp,h} ../lld/**/*.{cpp,h} llvm-svn: 366177
91 lines
3.2 KiB
C++
91 lines
3.2 KiB
C++
//===- OSObjectCStyleCast.cpp ------------------------------------*- C++ -*-==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines OSObjectCStyleCast checker, which checks for C-style casts
|
|
// of OSObjects. Such casts almost always indicate a code smell,
|
|
// as an explicit static or dynamic cast should be used instead.
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
using namespace ast_matchers;
|
|
|
|
namespace {
|
|
|
|
const char *WarnAtNode = "OSObjCast";
|
|
|
|
class OSObjectCStyleCastChecker : public Checker<check::ASTCodeBody> {
|
|
public:
|
|
void checkASTCodeBody(const Decl *D,
|
|
AnalysisManager &AM,
|
|
BugReporter &BR) const;
|
|
};
|
|
|
|
static void emitDiagnostics(const BoundNodes &Nodes,
|
|
BugReporter &BR,
|
|
AnalysisDeclContext *ADC,
|
|
const OSObjectCStyleCastChecker *Checker) {
|
|
const auto *CE = Nodes.getNodeAs<CastExpr>(WarnAtNode);
|
|
assert(CE);
|
|
|
|
std::string Diagnostics;
|
|
llvm::raw_string_ostream OS(Diagnostics);
|
|
OS << "C-style cast of OSObject. Use OSDynamicCast instead.";
|
|
|
|
BR.EmitBasicReport(
|
|
ADC->getDecl(),
|
|
Checker,
|
|
/*Name=*/"OSObject C-Style Cast",
|
|
/*BugCategory=*/"Security",
|
|
OS.str(),
|
|
PathDiagnosticLocation::createBegin(CE, BR.getSourceManager(), ADC),
|
|
CE->getSourceRange());
|
|
}
|
|
|
|
static auto hasTypePointingTo(DeclarationMatcher DeclM)
|
|
-> decltype(hasType(pointerType())) {
|
|
return hasType(pointerType(pointee(hasDeclaration(DeclM))));
|
|
}
|
|
|
|
void OSObjectCStyleCastChecker::checkASTCodeBody(const Decl *D, AnalysisManager &AM,
|
|
BugReporter &BR) const {
|
|
|
|
AnalysisDeclContext *ADC = AM.getAnalysisDeclContext(D);
|
|
|
|
auto DynamicCastM = callExpr(callee(functionDecl(hasName("safeMetaCast"))));
|
|
|
|
auto OSObjTypeM = hasTypePointingTo(cxxRecordDecl(isDerivedFrom("OSMetaClassBase")));
|
|
auto OSObjSubclassM = hasTypePointingTo(
|
|
cxxRecordDecl(isDerivedFrom("OSObject")));
|
|
|
|
auto CastM = cStyleCastExpr(
|
|
allOf(hasSourceExpression(allOf(OSObjTypeM, unless(DynamicCastM))),
|
|
OSObjSubclassM)).bind(WarnAtNode);
|
|
|
|
auto Matches = match(stmt(forEachDescendant(CastM)), *D->getBody(), AM.getASTContext());
|
|
for (BoundNodes Match : Matches)
|
|
emitDiagnostics(Match, BR, ADC, this);
|
|
}
|
|
}
|
|
|
|
void ento::registerOSObjectCStyleCast(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<OSObjectCStyleCastChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterOSObjectCStyleCast(const LangOptions &LO) {
|
|
return true;
|
|
}
|