8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
61 lines
1.8 KiB
C++
61 lines
1.8 KiB
C++
//===-- ClangExpressionHelper.h ---------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_ClangExpression_h_
|
|
#define liblldb_ClangExpression_h_
|
|
|
|
#include <map>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
|
|
#include "lldb/Core/ClangForward.h"
|
|
#include "lldb/Expression/ExpressionTypeSystemHelper.h"
|
|
#include "lldb/lldb-forward.h"
|
|
#include "lldb/lldb-private.h"
|
|
|
|
namespace lldb_private {
|
|
|
|
class RecordingMemoryManager;
|
|
|
|
// ClangExpressionHelper
|
|
class ClangExpressionHelper : public ExpressionTypeSystemHelper {
|
|
public:
|
|
static bool classof(const ExpressionTypeSystemHelper *ts) {
|
|
return ts->getKind() == eKindClangHelper;
|
|
}
|
|
|
|
ClangExpressionHelper()
|
|
: ExpressionTypeSystemHelper(
|
|
ExpressionTypeSystemHelper::LLVMCastKind::eKindClangHelper) {}
|
|
|
|
/// Destructor
|
|
virtual ~ClangExpressionHelper() {}
|
|
|
|
/// Return the object that the parser should use when resolving external
|
|
/// values. May be NULL if everything should be self-contained.
|
|
virtual ClangExpressionDeclMap *DeclMap() = 0;
|
|
|
|
/// Return the object that the parser should allow to access ASTs.
|
|
/// May be NULL if the ASTs do not need to be transformed.
|
|
///
|
|
/// \param[in] passthrough
|
|
/// The ASTConsumer that the returned transformer should send
|
|
/// the ASTs to after transformation.
|
|
virtual clang::ASTConsumer *
|
|
ASTTransformer(clang::ASTConsumer *passthrough) = 0;
|
|
|
|
virtual void CommitPersistentDecls() {}
|
|
|
|
protected:
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_ClangExpression_h_
|