Files
clang-p2996/lldb/source/Plugins/Language/CPlusPlus/LibCxxOptional.cpp
Adrian Prantl 0e4c482124 Pass ConstString by value (NFC)
My apologies for the large patch. With the exception of ConstString.h
itself it was entirely produced by sed.

ConstString has exactly one const char * data member, so passing a
ConstString by reference is not any more efficient than copying it by
value. In both cases a single pointer is passed. But passing it by
value makes it harder to accidentally return the address of a local
object.

(This fixes rdar://problem/48640859 for the Apple folks)

Differential Revision: https://reviews.llvm.org/D59030

llvm-svn: 355553
2019-03-06 21:22:25 +00:00

85 lines
2.5 KiB
C++

//===-- LibCxxOptional.cpp --------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "LibCxx.h"
#include "lldb/DataFormatters/FormattersHelpers.h"
using namespace lldb;
using namespace lldb_private;
namespace {
class OptionalFrontEnd : public SyntheticChildrenFrontEnd {
public:
OptionalFrontEnd(ValueObject &valobj) : SyntheticChildrenFrontEnd(valobj) {
Update();
}
size_t GetIndexOfChildWithName(ConstString name) override {
return formatters::ExtractIndexFromString(name.GetCString());
}
bool MightHaveChildren() override { return true; }
bool Update() override;
size_t CalculateNumChildren() override { return m_size; }
ValueObjectSP GetChildAtIndex(size_t idx) override;
private:
size_t m_size = 0;
ValueObjectSP m_base_sp;
};
} // namespace
bool OptionalFrontEnd::Update() {
ValueObjectSP engaged_sp(
m_backend.GetChildMemberWithName(ConstString("__engaged_"), true));
if (!engaged_sp)
return false;
// __engaged_ is a bool flag and is true if the optional contains a value.
// Converting it to unsigned gives us a size of 1 if it contains a value
// and 0 if not.
m_size = engaged_sp->GetValueAsUnsigned(0);
return false;
}
ValueObjectSP OptionalFrontEnd::GetChildAtIndex(size_t idx) {
if (idx >= m_size)
return ValueObjectSP();
// __val_ contains the underlying value of an optional if it has one.
// Currently because it is part of an anonymous union GetChildMemberWithName()
// does not peer through and find it unless we are at the parent itself.
// We can obtain the parent through __engaged_.
ValueObjectSP val_sp(
m_backend.GetChildMemberWithName(ConstString("__engaged_"), true)
->GetParent()
->GetChildAtIndex(0, true)
->GetChildMemberWithName(ConstString("__val_"), true));
if (!val_sp)
return ValueObjectSP();
CompilerType holder_type = val_sp->GetCompilerType();
if (!holder_type)
return ValueObjectSP();
return val_sp->Clone(ConstString(llvm::formatv("Value").str()));
}
SyntheticChildrenFrontEnd *
formatters::LibcxxOptionalFrontEndCreator(CXXSyntheticChildren *,
lldb::ValueObjectSP valobj_sp) {
if (valobj_sp)
return new OptionalFrontEnd(*valobj_sp);
return nullptr;
}