8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
76 lines
2.8 KiB
C++
76 lines
2.8 KiB
C++
//===-- ObjectContainerUniversalMachO.h -------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_ObjectContainerUniversalMachO_h_
|
|
#define liblldb_ObjectContainerUniversalMachO_h_
|
|
|
|
#include "lldb/Host/SafeMachO.h"
|
|
#include "lldb/Symbol/ObjectContainer.h"
|
|
#include "lldb/Utility/FileSpec.h"
|
|
|
|
class ObjectContainerUniversalMachO : public lldb_private::ObjectContainer {
|
|
public:
|
|
ObjectContainerUniversalMachO(const lldb::ModuleSP &module_sp,
|
|
lldb::DataBufferSP &data_sp,
|
|
lldb::offset_t data_offset,
|
|
const lldb_private::FileSpec *file,
|
|
lldb::offset_t offset, lldb::offset_t length);
|
|
|
|
~ObjectContainerUniversalMachO() override;
|
|
|
|
// Static Functions
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
static lldb_private::ConstString GetPluginNameStatic();
|
|
|
|
static const char *GetPluginDescriptionStatic();
|
|
|
|
static lldb_private::ObjectContainer *
|
|
CreateInstance(const lldb::ModuleSP &module_sp, lldb::DataBufferSP &data_sp,
|
|
lldb::offset_t data_offset, const lldb_private::FileSpec *file,
|
|
lldb::offset_t offset, lldb::offset_t length);
|
|
|
|
static size_t GetModuleSpecifications(const lldb_private::FileSpec &file,
|
|
lldb::DataBufferSP &data_sp,
|
|
lldb::offset_t data_offset,
|
|
lldb::offset_t file_offset,
|
|
lldb::offset_t length,
|
|
lldb_private::ModuleSpecList &specs);
|
|
|
|
static bool MagicBytesMatch(const lldb_private::DataExtractor &data);
|
|
|
|
// Member Functions
|
|
bool ParseHeader() override;
|
|
|
|
void Dump(lldb_private::Stream *s) const override;
|
|
|
|
size_t GetNumArchitectures() const override;
|
|
|
|
bool GetArchitectureAtIndex(uint32_t cpu_idx,
|
|
lldb_private::ArchSpec &arch) const override;
|
|
|
|
lldb::ObjectFileSP GetObjectFile(const lldb_private::FileSpec *file) override;
|
|
|
|
// PluginInterface protocol
|
|
lldb_private::ConstString GetPluginName() override;
|
|
|
|
uint32_t GetPluginVersion() override;
|
|
|
|
protected:
|
|
llvm::MachO::fat_header m_header;
|
|
std::vector<llvm::MachO::fat_arch> m_fat_archs;
|
|
|
|
static bool ParseHeader(lldb_private::DataExtractor &data,
|
|
llvm::MachO::fat_header &header,
|
|
std::vector<llvm::MachO::fat_arch> &fat_archs);
|
|
};
|
|
|
|
#endif // liblldb_ObjectContainerUniversalMachO_h_
|