8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
87 lines
2.4 KiB
C++
87 lines
2.4 KiB
C++
//===-- PlatformAndroid.h ---------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_PlatformAndroid_h_
|
|
#define liblldb_PlatformAndroid_h_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "Plugins/Platform/Linux/PlatformLinux.h"
|
|
|
|
#include "AdbClient.h"
|
|
|
|
namespace lldb_private {
|
|
namespace platform_android {
|
|
|
|
class PlatformAndroid : public platform_linux::PlatformLinux {
|
|
public:
|
|
PlatformAndroid(bool is_host);
|
|
|
|
~PlatformAndroid() override;
|
|
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
// lldb_private::PluginInterface functions
|
|
static lldb::PlatformSP CreateInstance(bool force, const ArchSpec *arch);
|
|
|
|
static ConstString GetPluginNameStatic(bool is_host);
|
|
|
|
static const char *GetPluginDescriptionStatic(bool is_host);
|
|
|
|
ConstString GetPluginName() override;
|
|
|
|
uint32_t GetPluginVersion() override { return 1; }
|
|
|
|
// lldb_private::Platform functions
|
|
|
|
Status ConnectRemote(Args &args) override;
|
|
|
|
Status GetFile(const FileSpec &source, const FileSpec &destination) override;
|
|
|
|
Status PutFile(const FileSpec &source, const FileSpec &destination,
|
|
uint32_t uid = UINT32_MAX, uint32_t gid = UINT32_MAX) override;
|
|
|
|
uint32_t GetSdkVersion();
|
|
|
|
bool GetRemoteOSVersion() override;
|
|
|
|
Status DisconnectRemote() override;
|
|
|
|
uint32_t GetDefaultMemoryCacheLineSize() override;
|
|
|
|
protected:
|
|
const char *GetCacheHostname() override;
|
|
|
|
Status DownloadModuleSlice(const FileSpec &src_file_spec,
|
|
const uint64_t src_offset, const uint64_t src_size,
|
|
const FileSpec &dst_file_spec) override;
|
|
|
|
Status DownloadSymbolFile(const lldb::ModuleSP &module_sp,
|
|
const FileSpec &dst_file_spec) override;
|
|
|
|
llvm::StringRef
|
|
GetLibdlFunctionDeclarations(lldb_private::Process *process) override;
|
|
|
|
private:
|
|
AdbClient::SyncService *GetSyncService(Status &error);
|
|
|
|
std::unique_ptr<AdbClient::SyncService> m_adb_sync_svc;
|
|
std::string m_device_id;
|
|
uint32_t m_sdk_version;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(PlatformAndroid);
|
|
};
|
|
|
|
} // namespace platofor_android
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_PlatformAndroid_h_
|