8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
84 lines
2.7 KiB
C++
84 lines
2.7 KiB
C++
//===-- PlatformMacOSX.h ----------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_PlatformMacOSX_h_
|
|
#define liblldb_PlatformMacOSX_h_
|
|
|
|
#include "PlatformDarwin.h"
|
|
|
|
class PlatformMacOSX : public PlatformDarwin {
|
|
public:
|
|
PlatformMacOSX(bool is_host);
|
|
|
|
~PlatformMacOSX() override;
|
|
|
|
// Class functions
|
|
static lldb::PlatformSP CreateInstance(bool force,
|
|
const lldb_private::ArchSpec *arch);
|
|
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
static lldb_private::ConstString GetPluginNameStatic(bool is_host);
|
|
|
|
static const char *GetDescriptionStatic(bool is_host);
|
|
|
|
// lldb_private::PluginInterface functions
|
|
lldb_private::ConstString GetPluginName() override {
|
|
return GetPluginNameStatic(IsHost());
|
|
}
|
|
|
|
uint32_t GetPluginVersion() override { return 1; }
|
|
|
|
lldb_private::Status
|
|
GetSharedModule(const lldb_private::ModuleSpec &module_spec,
|
|
lldb_private::Process *process, lldb::ModuleSP &module_sp,
|
|
const lldb_private::FileSpecList *module_search_paths_ptr,
|
|
lldb::ModuleSP *old_module_sp_ptr,
|
|
bool *did_create_ptr) override;
|
|
|
|
const char *GetDescription() override {
|
|
return GetDescriptionStatic(IsHost());
|
|
}
|
|
|
|
lldb_private::Status
|
|
GetSymbolFile(const lldb_private::FileSpec &platform_file,
|
|
const lldb_private::UUID *uuid_ptr,
|
|
lldb_private::FileSpec &local_file);
|
|
|
|
lldb_private::Status
|
|
GetFile(const lldb_private::FileSpec &source,
|
|
const lldb_private::FileSpec &destination) override {
|
|
return PlatformDarwin::GetFile(source, destination);
|
|
}
|
|
|
|
lldb_private::Status
|
|
GetFileWithUUID(const lldb_private::FileSpec &platform_file,
|
|
const lldb_private::UUID *uuid_ptr,
|
|
lldb_private::FileSpec &local_file) override;
|
|
|
|
bool GetSupportedArchitectureAtIndex(uint32_t idx,
|
|
lldb_private::ArchSpec &arch) override;
|
|
|
|
lldb_private::ConstString
|
|
GetSDKDirectory(lldb_private::Target &target) override;
|
|
|
|
void
|
|
AddClangModuleCompilationOptions(lldb_private::Target *target,
|
|
std::vector<std::string> &options) override {
|
|
return PlatformDarwin::AddClangModuleCompilationOptionsForSDKType(
|
|
target, options, PlatformDarwin::SDKType::MacOSX);
|
|
}
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(PlatformMacOSX);
|
|
};
|
|
|
|
#endif // liblldb_PlatformMacOSX_h_
|