Files
clang-p2996/lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h
Jonas Devlieghere 8b3af63b89 [NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135
2019-04-10 20:48:55 +00:00

73 lines
1.8 KiB
C++

//===-- ThreadKDP.h ---------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef liblldb_ThreadKDP_h_
#define liblldb_ThreadKDP_h_
#include <string>
#include "lldb/Target/Process.h"
#include "lldb/Target/Thread.h"
class ProcessKDP;
class ThreadKDP : public lldb_private::Thread {
public:
ThreadKDP(lldb_private::Process &process, lldb::tid_t tid);
virtual ~ThreadKDP();
virtual void RefreshStateAfterStop();
virtual const char *GetName();
virtual const char *GetQueueName();
virtual lldb::RegisterContextSP GetRegisterContext();
virtual lldb::RegisterContextSP
CreateRegisterContextForFrame(lldb_private::StackFrame *frame);
void Dump(lldb_private::Log *log, uint32_t index);
static bool ThreadIDIsValid(lldb::tid_t thread);
bool ShouldStop(bool &step_more);
const char *GetBasicInfoAsString();
void SetName(const char *name) {
if (name && name[0])
m_thread_name.assign(name);
else
m_thread_name.clear();
}
lldb::addr_t GetThreadDispatchQAddr() { return m_thread_dispatch_qaddr; }
void SetThreadDispatchQAddr(lldb::addr_t thread_dispatch_qaddr) {
m_thread_dispatch_qaddr = thread_dispatch_qaddr;
}
void SetStopInfoFrom_KDP_EXCEPTION(
const lldb_private::DataExtractor &exc_reply_packet);
protected:
friend class ProcessKDP;
// Member variables.
std::string m_thread_name;
std::string m_dispatch_queue_name;
lldb::addr_t m_thread_dispatch_qaddr;
lldb::StopInfoSP m_cached_stop_info_sp;
// Protected member functions.
virtual bool CalculateStopInfo();
};
#endif // liblldb_ThreadKDP_h_