8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
54 lines
1.6 KiB
C++
54 lines
1.6 KiB
C++
//===-- UnwindMacOSXFrameBackchain.h ----------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef lldb_UnwindMacOSXFrameBackchain_h_
|
|
#define lldb_UnwindMacOSXFrameBackchain_h_
|
|
|
|
#include <vector>
|
|
|
|
#include "lldb/Target/Unwind.h"
|
|
#include "lldb/lldb-private.h"
|
|
|
|
class UnwindMacOSXFrameBackchain : public lldb_private::Unwind {
|
|
public:
|
|
UnwindMacOSXFrameBackchain(lldb_private::Thread &thread);
|
|
|
|
~UnwindMacOSXFrameBackchain() override = default;
|
|
|
|
protected:
|
|
void DoClear() override { m_cursors.clear(); }
|
|
|
|
uint32_t DoGetFrameCount() override;
|
|
|
|
bool DoGetFrameInfoAtIndex(uint32_t frame_idx, lldb::addr_t &cfa,
|
|
lldb::addr_t &pc) override;
|
|
|
|
lldb::RegisterContextSP
|
|
DoCreateRegisterContextForFrame(lldb_private::StackFrame *frame) override;
|
|
|
|
friend class RegisterContextMacOSXFrameBackchain;
|
|
|
|
struct Cursor {
|
|
lldb::addr_t pc; // Program counter
|
|
lldb::addr_t fp; // Frame pointer for us with backchain
|
|
};
|
|
|
|
private:
|
|
std::vector<Cursor> m_cursors;
|
|
|
|
size_t GetStackFrameData_i386(const lldb_private::ExecutionContext &exe_ctx);
|
|
|
|
size_t
|
|
GetStackFrameData_x86_64(const lldb_private::ExecutionContext &exe_ctx);
|
|
|
|
// For UnwindMacOSXFrameBackchain only
|
|
DISALLOW_COPY_AND_ASSIGN(UnwindMacOSXFrameBackchain);
|
|
};
|
|
|
|
#endif // lldb_UnwindMacOSXFrameBackchain_h_
|