0683c0e68d
Summary: This patch tackles long hanging fruit for the builtin operator<=> expressions. It is currently needs some cleanup before landing, but I want to get some initial feedback. The main changes are: * Lookup, build, and store the required standard library types and expressions in `ASTContext`. By storing them in ASTContext we don't need to store (and duplicate) the required expressions in the BinaryOperator AST nodes. * Implement [expr.spaceship] checking, including diagnosing narrowing conversions. * Implement `ExprConstant` for builtin spaceship operators. * Implement builitin operator<=> support in `CodeGenAgg`. Initially I emitted the required comparisons using `ScalarExprEmitter::VisitBinaryOperator`, but this caused the operand expressions to be emitted once for every required cmp. * Implement [builtin.over] with modifications to support the intent of P0946R0. See the note on `BuiltinOperatorOverloadBuilder::addThreeWayArithmeticOverloads` for more information about the workaround. Reviewers: rsmith, aaron.ballman, majnemer, rnk, compnerd, rjmccall Reviewed By: rjmccall Subscribers: rjmccall, rsmith, aaron.ballman, junbuml, mgorny, cfe-commits Differential Revision: https://reviews.llvm.org/D45476 llvm-svn: 331677
29 lines
493 B
C++
29 lines
493 B
C++
// RUN: %clang_cc1 -pedantic-errors -std=c++2a -emit-pch %s -o %t
|
|
// RUN: %clang_cc1 -pedantic-errors -std=c++2a -include-pch %t -verify %s
|
|
// RUN: %clang_cc1 -pedantic-errors -std=c++2a -include-pch %t -emit-llvm %s -o -
|
|
|
|
|
|
#ifndef HEADER
|
|
#define HEADER
|
|
|
|
#include "Inputs/std-compare.h"
|
|
constexpr auto foo() {
|
|
return (42 <=> 101);
|
|
}
|
|
|
|
inline auto bar(int x) {
|
|
return (1 <=> x);
|
|
}
|
|
|
|
#else
|
|
|
|
// expected-no-diagnostics
|
|
|
|
static_assert(foo() < 0);
|
|
|
|
auto bar2(int x) {
|
|
return bar(x);
|
|
}
|
|
|
|
#endif
|