I'm not sure if this fix is the right thing to do, but it seemed to me that PATCHABLE_RET and PATCHABLE_TAIL_CALL don't have any defs. Running the following: ``` LLVM_ENABLE_MACHINE_VERIFIER=1 ./build/bin/llvm-lit -v -a test/CodeGen/X86/xray-* ``` results in the following tests to fail (along others): ``` LLVM :: CodeGen/X86/xray-attribute-instrumentation.ll LLVM :: CodeGen/X86/xray-custom-log.ll LLVM :: CodeGen/X86/xray-log-args.ll LLVM :: CodeGen/X86/xray-loop-detection.ll LLVM :: CodeGen/X86/xray-multiplerets-in-blocks.mir LLVM :: CodeGen/X86/xray-section-group.ll LLVM :: CodeGen/X86/xray-selective-instrumentation.ll LLVM :: CodeGen/X86/xray-tail-call-sled.ll LLVM :: CodeGen/X86/xray-typed-event-log.ll ``` The errors are: ``` *** Bad machine code: Explicit definition must be a register *** - function: fn - basic block: %bb.0 (0x7fa31a84d908) - instruction: PATCHABLE_RET 2560, $eax - operand 0: 2560 ``` and ``` *** Bad machine code: Explicit definition must be a register *** - function: caller - basic block: %bb.0 (0x7fbff3044108) - instruction: PATCHABLE_TAIL_CALL 3009, @callee, <regmask $bh $bl $bp $bph $bpl $bx $ebp $ebx $hbp $hbx $rbp $rbx $r12 $r13 $r14 $r15 $r12b $r13b $r14b $r15b $r12bh $r13bh $r14bh $r15bh $r12d $r13d $r14d $r15d $r12w $r13w $r14w $r15w $r12wh and 3 more...>, implicit $rsp, implicit $ssp, implicit $rsp, implicit $ssp, implicit $edi - operand 0: 3009 ``` Differential Revision: https://reviews.llvm.org/D49187 llvm-svn: 336906
37 lines
1.3 KiB
LLVM
37 lines
1.3 KiB
LLVM
; RUN: llc -verify-machineinstrs -filetype=asm -o - -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s
|
|
; RUN: llc -verify-machineinstrs -filetype=asm -o - \
|
|
; RUN: -mtriple=x86_64-unknown-linux-gnu -relocation-model=pic < %s | FileCheck %s -check-prefix=PIC
|
|
|
|
define i32 @fn() nounwind noinline uwtable "function-instrument"="xray-always" {
|
|
%eventptr = alloca i8
|
|
%eventsize = alloca i32
|
|
store i32 3, i32* %eventsize
|
|
%val = load i32, i32* %eventsize
|
|
call void @llvm.xray.customevent(i8* %eventptr, i32 %val)
|
|
; CHECK-LABEL: Lxray_event_sled_0:
|
|
; CHECK: .byte 0xeb, 0x0f
|
|
; CHECK-NEXT: pushq %rdi
|
|
; CHECK-NEXT: pushq %rsi
|
|
; CHECK-NEXT: movq {{.*}}, %rdi
|
|
; CHECK-NEXT: movq {{.*}}, %rsi
|
|
; CHECK-NEXT: callq __xray_CustomEvent
|
|
; CHECK-NEXT: popq %rsi
|
|
; CHECK-NEXT: popq %rdi
|
|
|
|
; PIC-LABEL: Lxray_event_sled_0:
|
|
; PIC: .byte 0xeb, 0x0f
|
|
; PIC-NEXT: pushq %rdi
|
|
; PIC-NEXT: pushq %rsi
|
|
; PIC-NEXT: movq {{.*}}, %rdi
|
|
; PIC-NEXT: movq {{.*}}, %rsi
|
|
; PIC-NEXT: callq __xray_CustomEvent@PLT
|
|
; PIC-NEXT: popq %rsi
|
|
; PIC-NEXT: popq %rdi
|
|
ret i32 0
|
|
}
|
|
; CHECK-LABEL: xray_instr_map
|
|
; CHECK-LABEL: Lxray_sleds_start0:
|
|
; CHECK: .quad {{.*}}xray_event_sled_0
|
|
|
|
declare void @llvm.xray.customevent(i8*, i32)
|