7693b116a1
In commit r219005 lifetime markers have been introduced to mark the lifetime of the OpenMP context data structure. However, their use seems incorrect and recently caused a miscompile in ASC_Sequoia/CrystalMk after r298053 which was not at all related to r298053. r298053 only caused a change in the loop order, as this change resulted in a different isl internal representation which caused the scheduler to derive a different schedule. This change then caused the IR to change, which apparently created a pattern in which LLVM exploites the lifetime markers. It seems we are using the OpenMP context outside of the lifetime markers. Even though CrystalMk could probably be fixed by expanding the scope of the lifetime markers, it is not clear what happens in case the OpenMP function call is in a loop which will cause a sequence of starting and ending lifetimes. As it is unlikely that the lifetime markers give any performance benefit, we just drop them to remove complexity. llvm-svn: 298192
100 lines
4.0 KiB
LLVM
100 lines
4.0 KiB
LLVM
; RUN: opt %loadPolly -polly-parallel -polly-ast -analyze < %s | FileCheck %s -check-prefix=AST
|
|
; RUN: opt %loadPolly -polly-parallel -polly-codegen -S < %s | FileCheck %s -check-prefix=IR
|
|
;
|
|
; float A[100];
|
|
;
|
|
; void loop_references_outer_ids(long n) {
|
|
; for (long i = 0; i < 100; i++)
|
|
; for (long j = 0; j < 100; j++)
|
|
; for (long k = 0; k < n + i; k++)
|
|
; A[j] += i + j + k;
|
|
; }
|
|
|
|
; In this test case we verify that the j-loop is generated as OpenMP parallel
|
|
; loop and that the values of 'i' and 'n', needed in the loop bounds of the
|
|
; k-loop, are correctly passed to the subfunction.
|
|
|
|
; AST: #pragma minimal dependence distance: 1
|
|
; AST: for (int c0 = max(0, -n + 1); c0 <= 99; c0 += 1)
|
|
; AST: #pragma omp parallel for
|
|
; AST: for (int c1 = 0; c1 <= 99; c1 += 1)
|
|
; AST: #pragma minimal dependence distance: 1
|
|
; AST: for (int c2 = 0; c2 < n + c0; c2 += 1)
|
|
; AST: Stmt_for_body6(c0, c1, c2);
|
|
|
|
; IR: %polly.par.userContext = alloca { i64, i64 }
|
|
; IR: %[[R1:[0-9a-z.]+]] = getelementptr inbounds { i64, i64 }, { i64, i64 }* %polly.par.userContext, i32 0, i32 0
|
|
; IR-NEXT: store i64 %n, i64* %[[R1]]
|
|
; IR-NEXT: %[[R2:[0-9a-z.]+]] = getelementptr inbounds { i64, i64 }, { i64, i64 }* %polly.par.userContext, i32 0, i32 1
|
|
; IR-NEXT: store i64 %polly.indvar, i64* %[[R2]]
|
|
; IR-NEXT: %polly.par.userContext1 = bitcast { i64, i64 }* %polly.par.userContext to i8*
|
|
|
|
; IR-LABEL: @loop_references_outer_ids_polly_subfn(i8* %polly.par.userContext)
|
|
; IR: %polly.par.userContext1 = bitcast i8* %polly.par.userContext to { i64, i64 }*
|
|
; IR-NEXT: %[[R3:[0-9a-z.]+]] = getelementptr inbounds { i64, i64 }, { i64, i64 }* %polly.par.userContext1, i32 0, i32 0
|
|
; IR-NEXT: %[[R4:[0-9a-z.]+]] = load i64, i64* %[[R3]]
|
|
; IR-NEXT: %[[R5:[0-9a-z.]+]] = getelementptr inbounds { i64, i64 }, { i64, i64 }* %polly.par.userContext1, i32 0, i32 1
|
|
; IR-NEXT: %[[R6:[0-9a-z.]+]] = load i64, i64* %[[R5]]
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
@A = common global [100 x float] zeroinitializer, align 16
|
|
|
|
define void @loop_references_outer_ids(i64 %n) {
|
|
entry:
|
|
br label %for.cond
|
|
|
|
for.cond: ; preds = %for.inc03, %entry
|
|
%i.0 = phi i64 [ 0, %entry ], [ %inc04, %for.inc03 ]
|
|
%exitcond1 = icmp ne i64 %i.0, 100
|
|
br i1 %exitcond1, label %for.body, label %for.end15
|
|
|
|
for.body: ; preds = %for.cond
|
|
br label %for.cond1
|
|
|
|
for.cond1: ; preds = %for.inc00, %for.body
|
|
%j.0 = phi i64 [ 0, %for.body ], [ %inc01, %for.inc00 ]
|
|
%exitcond = icmp ne i64 %j.0, 100
|
|
br i1 %exitcond, label %for.body3, label %for.end12
|
|
|
|
for.body3: ; preds = %for.cond1
|
|
br label %for.cond4
|
|
|
|
for.cond4: ; preds = %for.inc, %for.body3
|
|
%k.0 = phi i64 [ 0, %for.body3 ], [ %inc, %for.inc ]
|
|
%add = add nsw i64 %i.0, %n
|
|
%cmp5 = icmp slt i64 %k.0, %add
|
|
br i1 %cmp5, label %for.body6, label %for.end
|
|
|
|
for.body6: ; preds = %for.cond4
|
|
%add7 = add nsw i64 %i.0, %j.0
|
|
%add8 = add nsw i64 %add7, %k.0
|
|
%conv = sitofp i64 %add8 to float
|
|
%arrayidx = getelementptr inbounds [100 x float], [100 x float]* @A, i64 0, i64 %j.0
|
|
%tmp = load float, float* %arrayidx, align 4
|
|
%add9 = fadd float %tmp, %conv
|
|
store float %add9, float* %arrayidx, align 4
|
|
br label %for.inc
|
|
|
|
for.inc: ; preds = %for.body6
|
|
%inc = add nsw i64 %k.0, 1
|
|
br label %for.cond4
|
|
|
|
for.end: ; preds = %for.cond4
|
|
br label %for.inc00
|
|
|
|
for.inc00: ; preds = %for.end
|
|
%inc01 = add nsw i64 %j.0, 1
|
|
br label %for.cond1
|
|
|
|
for.end12: ; preds = %for.cond1
|
|
br label %for.inc03
|
|
|
|
for.inc03: ; preds = %for.end12
|
|
%inc04 = add nsw i64 %i.0, 1
|
|
br label %for.cond
|
|
|
|
for.end15: ; preds = %for.cond
|
|
ret void
|
|
}
|