Tomas Matheson 6d4a3e917c Revert "[TableGen] Use heap allocated arrays instead of vectors for TreePatternNode::Types and ResultPerm. NFC" ...

While working on DAGISelMatcherEmitter I've hit several runtime errors
caused by accessing TreePatternNode::Types out of bounds. These were
difficult to debug because the switch from std::vector to unique_ptr
removes bounds checking.

I don't think the slight reduction in class size is worth the extra
debugging and memory safety problems, so I suggest we revert this.

This reverts commit d34125a1a8.

Differential Revision: https://reviews.llvm.org/D154781

2023-07-09 10:14:48 +01:00

46 KiB

Raw Blame History

View Raw