f56c30d13b
This cleanup is designed to make the https://reviews.llvm.org/D32167 patch smaller and easier to read. Cleanup in this patch: Allow DWARFUnit subclasses to hand out the data that should be used when decoding data for a DIE. The information might be in .debug_info or could be in .debug_types. There is a new virtual function on DWARFUnit that each subclass must override: virtual const lldb_private::DWARFDataExtractor &DWARFUnit::GetData() const; This allows DWARFCompileUnit and eventually DWARFTypeUnit to hand out different data to be used when decoding the DIE information. Add a new pure virtual function to get the size of the DWARF unit header: virtual uint32_t DWARFUnit::GetHeaderByteSize() const = 0; This allows DWARFCompileUnit and eventually DWARFTypeUnit to hand out different offsets where the first DIE starts when decoding DIE information from the unit. Added a new function to DWARFDataExtractor to get the size of an offset: size_t DWARFDataExtractor::GetDWARFSizeOfOffset() const; Removed dead dumping and parsing code in the DWARFDebugInfo class. Inlined a bunch of calls in DWARFUnit for accessors that were just returning integer member variables. Renamed DWARFUnit::Size() to DWARFUnit::GetHeaderByteSize() as it clearly states what it is doing and makes more sense. Differential Revision: https://reviews.llvm.org/D46606 llvm-svn: 331892
71 lines
2.5 KiB
C++
71 lines
2.5 KiB
C++
//===-- DWARFCompileUnit.cpp ------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "DWARFCompileUnit.h"
|
|
|
|
#include "SymbolFileDWARF.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
extern int g_verbose;
|
|
|
|
DWARFCompileUnit::DWARFCompileUnit(SymbolFileDWARF *dwarf2Data)
|
|
: DWARFUnit(dwarf2Data) {}
|
|
|
|
DWARFUnitSP DWARFCompileUnit::Extract(SymbolFileDWARF *dwarf2Data,
|
|
const DWARFDataExtractor &debug_info,
|
|
lldb::offset_t *offset_ptr) {
|
|
// std::make_shared would require the ctor to be public.
|
|
std::shared_ptr<DWARFCompileUnit> cu_sp(new DWARFCompileUnit(dwarf2Data));
|
|
|
|
cu_sp->m_offset = *offset_ptr;
|
|
|
|
if (debug_info.ValidOffset(*offset_ptr)) {
|
|
dw_offset_t abbr_offset;
|
|
const DWARFDebugAbbrev *abbr = dwarf2Data->DebugAbbrev();
|
|
cu_sp->m_length = debug_info.GetDWARFInitialLength(offset_ptr);
|
|
cu_sp->m_is_dwarf64 = debug_info.IsDWARF64();
|
|
cu_sp->m_version = debug_info.GetU16(offset_ptr);
|
|
abbr_offset = debug_info.GetDWARFOffset(offset_ptr);
|
|
cu_sp->m_addr_size = debug_info.GetU8(offset_ptr);
|
|
|
|
bool length_OK =
|
|
debug_info.ValidOffset(cu_sp->GetNextCompileUnitOffset() - 1);
|
|
bool version_OK = SymbolFileDWARF::SupportedVersion(cu_sp->m_version);
|
|
bool abbr_offset_OK =
|
|
dwarf2Data->get_debug_abbrev_data().ValidOffset(abbr_offset);
|
|
bool addr_size_OK = (cu_sp->m_addr_size == 4) || (cu_sp->m_addr_size == 8);
|
|
|
|
if (length_OK && version_OK && addr_size_OK && abbr_offset_OK &&
|
|
abbr != NULL) {
|
|
cu_sp->m_abbrevs = abbr->GetAbbreviationDeclarationSet(abbr_offset);
|
|
return cu_sp;
|
|
}
|
|
|
|
// reset the offset to where we tried to parse from if anything went wrong
|
|
*offset_ptr = cu_sp->m_offset;
|
|
}
|
|
|
|
return nullptr;
|
|
}
|
|
|
|
void DWARFCompileUnit::Dump(Stream *s) const {
|
|
s->Printf("0x%8.8x: Compile Unit: length = 0x%8.8x, version = 0x%4.4x, "
|
|
"abbr_offset = 0x%8.8x, addr_size = 0x%2.2x (next CU at "
|
|
"{0x%8.8x})\n",
|
|
m_offset, m_length, m_version, GetAbbrevOffset(), m_addr_size,
|
|
GetNextCompileUnitOffset());
|
|
}
|
|
|
|
|
|
const lldb_private::DWARFDataExtractor &DWARFCompileUnit::GetData() const {
|
|
return m_dwarf->get_debug_info_data();
|
|
}
|