f49a4440d3
An empty history entry can happen by entering the expression evaluator an immediately hitting enter: ``` $ lldb (lldb) e Enter expressions, then terminate with an empty line to evaluate: 1: <hit enter> ``` The next time the user enters the expression evaluator, if they hit the up arrow to load the previous expression, lldb crashes. This patch treats empty history sessions as a single expression of zero length, instead of an empty list of expressions. Fixes http://llvm.org/PR49845. Differential Revision: https://reviews.llvm.org/D100048
95 lines
3.7 KiB
Python
95 lines
3.7 KiB
Python
"""
|
|
Tests navigating in the multiline expression editor.
|
|
"""
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test.lldbpexpect import PExpectTest
|
|
|
|
class TestCase(PExpectTest):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
arrow_up = "\033[A"
|
|
arrow_down = "\033[B"
|
|
|
|
# PExpect uses many timeouts internally and doesn't play well
|
|
# under ASAN on a loaded machine..
|
|
@skipIfAsan
|
|
@skipIfEditlineSupportMissing
|
|
@expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr48316')
|
|
def test_nav_arrow_up(self):
|
|
"""Tests that we can navigate back to the previous line with the up arrow"""
|
|
self.launch()
|
|
|
|
# Start multiline expression mode by just running 'expr'
|
|
self.child.sendline("expr")
|
|
self.child.expect_exact("terminate with an empty line to evaluate")
|
|
# Create a simple integer expression '123' and press enter.
|
|
self.child.send("123\n")
|
|
# We should see the prompt for the second line of our expression.
|
|
self.child.expect_exact("2: ")
|
|
# Go back to the first line and change 123 to 124.
|
|
# Then press enter twice to evaluate our expression.
|
|
self.child.send(self.arrow_up + "\b4\n\n")
|
|
# The result of our expression should be 124 (our edited expression)
|
|
# and not 123 (the one we initially typed).
|
|
self.child.expect_exact("(int) $0 = 124")
|
|
|
|
self.quit()
|
|
|
|
@skipIfAsan
|
|
@skipIfEditlineSupportMissing
|
|
@expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr48316')
|
|
def test_nav_arrow_down(self):
|
|
"""Tests that we can navigate to the next line with the down arrow"""
|
|
self.launch()
|
|
|
|
# Start multiline expression mode by just running 'expr'
|
|
self.child.sendline("expr")
|
|
self.child.expect_exact("terminate with an empty line to evaluate")
|
|
# Create a simple integer expression '111' and press enter.
|
|
self.child.send("111\n")
|
|
# We should see the prompt for the second line of our expression.
|
|
self.child.expect_exact("2: ")
|
|
# Create another simple integer expression '222'.
|
|
self.child.send("222")
|
|
# Go back to the first line and change '111' to '111+' to make
|
|
# an addition operation that spans two lines. We need to go up to
|
|
# test that we can go back down again.
|
|
self.child.send(self.arrow_up + "+")
|
|
# Go back down to our second line and change '222' to '223'
|
|
# so that the full expression is now '111+\n223'.
|
|
# Then press enter twice to evaluate the expression.
|
|
self.child.send(self.arrow_down + "\b3\n\n")
|
|
# The result of our expression '111 + 223' should be '334'.
|
|
# If the expression is '333' then arrow down failed to get
|
|
# us back to the second line.
|
|
self.child.expect_exact("(int) $0 = 334")
|
|
|
|
self.quit()
|
|
|
|
@skipIfAsan
|
|
@skipIfEditlineSupportMissing
|
|
@expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr48316')
|
|
def test_nav_arrow_up_empty_pr49845(self):
|
|
"""Tests that navigating with the up arrow doesn't crash."""
|
|
self.launch()
|
|
|
|
# Create an empty history session by only entering a newline.
|
|
self.child.sendline("expr")
|
|
self.child.expect_exact("terminate with an empty line to evaluate")
|
|
self.child.send("\n")
|
|
self.expect_prompt()
|
|
|
|
# Send just the up arrow in the expression evaluator. This should bring up the previous empty expression.
|
|
self.child.sendline("expr")
|
|
self.child.expect_exact("terminate with an empty line to evaluate")
|
|
self.child.send(self.arrow_up)
|
|
self.child.expect_exact("1: ")
|
|
self.child.send("\n")
|
|
self.expect_prompt()
|
|
|
|
self.quit()
|