0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
79 lines
1.7 KiB
C++
79 lines
1.7 KiB
C++
// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm-only %s -verify -DTEST1
|
|
// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm-only %s -verify -DTEST2 -emit-llvm -o - | FileCheck %s
|
|
// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm-only %s -verify -DTEST3
|
|
// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm-only %s -verify -DTEST4
|
|
|
|
#ifdef TEST1
|
|
|
|
class MyClass {
|
|
static void meth();
|
|
};
|
|
void MyClass::meth() { } // expected-note {{previous}}
|
|
extern "C" {
|
|
void _ZN7MyClass4methEv() { } // expected-error {{definition with same mangled name '_ZN7MyClass4methEv' as another definition}}
|
|
}
|
|
|
|
#elif TEST2
|
|
|
|
// expected-no-diagnostics
|
|
|
|
// We expect no warnings here, as there is only declaration of _ZN1TD1Ev
|
|
// function, no definitions.
|
|
extern "C" void _ZN1TD1Ev();
|
|
struct T {
|
|
~T() {}
|
|
};
|
|
|
|
// We expect no warnings here, as there is only declaration of _ZN2nm3abcE
|
|
// global, no definitions.
|
|
extern "C" {
|
|
int _ZN2nm3abcE;
|
|
}
|
|
|
|
namespace nm {
|
|
float abc = 2;
|
|
}
|
|
// CHECK: @_ZN2nm3abcE = {{(dso_local )?}}global float
|
|
|
|
float foo() {
|
|
_ZN1TD1Ev();
|
|
// CHECK: call void @_ZN1TD1Ev()
|
|
T t;
|
|
// CHECK: call {{.*}} @_ZN1TD1Ev(ptr {{[^,]*}} %t)
|
|
return _ZN2nm3abcE + nm::abc;
|
|
}
|
|
|
|
#elif TEST3
|
|
|
|
extern "C" void _ZN2T2D2Ev() {}; // expected-note {{previous definition is here}}
|
|
|
|
struct T2 {
|
|
~T2() {} // expected-error {{definition with same mangled name '_ZN2T2D2Ev' as another definition}}
|
|
};
|
|
|
|
void foo() {
|
|
_ZN2T2D2Ev();
|
|
T2 t;
|
|
}
|
|
|
|
#elif TEST4
|
|
|
|
extern "C" {
|
|
int _ZN2nm3abcE = 1; // expected-note {{previous definition is here}}
|
|
}
|
|
|
|
namespace nm {
|
|
float abc = 2; // expected-error {{definition with same mangled name '_ZN2nm3abcE' as another definition}}
|
|
}
|
|
|
|
float foo() {
|
|
return _ZN2nm3abcE + nm::abc;
|
|
}
|
|
|
|
#else
|
|
|
|
#error Unknown test
|
|
|
|
#endif
|
|
|