Oleksandr "Alex" Zinenko 11140cc238 [mlir] mark ChangeResult as nodiscard (#76147) ...

This enum is used by dataflow analyses to indicate whether further
propagation is necessary to reach the fix point. Accidentally discarding
such a value will likely lead to propagation stopping early, leading to
incomplete or incorrect results. The most egregious example is the
duality between `join` on the analysis class, which triggers propagation
internally, and `join` on the lattice class that does not and expects
the caller to trigger it depending on the returned `ChangeResult`.

2023-12-21 17:58:53 +01:00

5.7 KiB

Raw Blame History

View Raw