5550c82189
The MLIR classes Type/Attribute/Operation/Op/Value support cast/dyn_cast/isa/dyn_cast_or_null functionality through llvm's doCast functionality in addition to defining methods with the same name. This change begins the migration of uses of the method to the corresponding function call as has been decided as more consistent. Note that there still exist classes that only define methods directly, such as AffineExpr, and this does not include work currently to support a functional cast/isa call. Caveats include: - This clang-tidy script probably has more problems. - This only touches C++ code, so nothing that is being generated. Context: - https://mlir.llvm.org/deprecation/ at "Use the free function variants for dyn_cast/cast/isa/…" - Original discussion at https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443 Implementation: This first patch was created with the following steps. The intention is to only do automated changes at first, so I waste less time if it's reverted, and so the first mass change is more clear as an example to other teams that will need to follow similar steps. Steps are described per line, as comments are removed by git: 0. Retrieve the change from the following to build clang-tidy with an additional check: https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check 1. Build clang-tidy 2. Run clang-tidy over your entire codebase while disabling all checks and enabling the one relevant one. Run on all header files also. 3. Delete .inc files that were also modified, so the next build rebuilds them to a pure state. 4. Some changes have been deleted for the following reasons: - Some files had a variable also named cast - Some files had not included a header file that defines the cast functions - Some files are definitions of the classes that have the casting methods, so the code still refers to the method instead of the function without adding a prefix or removing the method declaration at the same time. ``` ninja -C $BUILD_DIR clang-tidy run-clang-tidy -clang-tidy-binary=$BUILD_DIR/bin/clang-tidy -checks='-*,misc-cast-functions'\ -header-filter=mlir/ mlir/* -fix rm -rf $BUILD_DIR/tools/mlir/**/*.inc git restore mlir/lib/IR mlir/lib/Dialect/DLTI/DLTI.cpp\ mlir/lib/Dialect/Complex/IR/ComplexDialect.cpp\ mlir/lib/**/IR/\ mlir/lib/Dialect/SparseTensor/Transforms/SparseVectorization.cpp\ mlir/lib/Dialect/Vector/Transforms/LowerVectorMultiReduction.cpp\ mlir/test/lib/Dialect/Test/TestTypes.cpp\ mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp\ mlir/test/lib/Dialect/Test/TestAttributes.cpp\ mlir/unittests/TableGen/EnumsGenTest.cpp\ mlir/test/python/lib/PythonTestCAPI.cpp\ mlir/include/mlir/IR/ ``` Differential Revision: https://reviews.llvm.org/D150123
73 lines
2.4 KiB
C++
73 lines
2.4 KiB
C++
//===- TestDiagnostics.cpp - Test Diagnostic Utilities --------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains test passes for constructing and resolving dominance
|
|
// information.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/IR/SymbolTable.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
#include "llvm/Support/SourceMgr.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
struct TestDiagnosticFilterPass
|
|
: public PassWrapper<TestDiagnosticFilterPass,
|
|
InterfacePass<SymbolOpInterface>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestDiagnosticFilterPass)
|
|
|
|
StringRef getArgument() const final { return "test-diagnostic-filter"; }
|
|
StringRef getDescription() const final {
|
|
return "Test diagnostic filtering support.";
|
|
}
|
|
TestDiagnosticFilterPass() = default;
|
|
TestDiagnosticFilterPass(const TestDiagnosticFilterPass &) {}
|
|
|
|
void runOnOperation() override {
|
|
llvm::errs() << "Test '" << getOperation().getName() << "'\n";
|
|
|
|
// Build a diagnostic handler that has filtering capabilities.
|
|
auto filterFn = [&](Location loc) {
|
|
// Ignore non-file locations.
|
|
FileLineColLoc fileLoc = dyn_cast<FileLineColLoc>(loc);
|
|
if (!fileLoc)
|
|
return true;
|
|
|
|
// Don't show file locations if their name contains a filter.
|
|
return llvm::none_of(filters, [&](StringRef filter) {
|
|
return fileLoc.getFilename().strref().contains(filter);
|
|
});
|
|
};
|
|
llvm::SourceMgr sourceMgr;
|
|
SourceMgrDiagnosticHandler handler(sourceMgr, &getContext(), llvm::errs(),
|
|
filterFn);
|
|
|
|
// Emit a diagnostic for every operation with a valid loc.
|
|
getOperation()->walk([&](Operation *op) {
|
|
if (LocationAttr locAttr = op->getAttrOfType<LocationAttr>("test.loc"))
|
|
emitError(locAttr, "test diagnostic");
|
|
});
|
|
}
|
|
|
|
ListOption<std::string> filters{
|
|
*this, "filters",
|
|
llvm::cl::desc("Specifies the diagnostic file name filters.")};
|
|
};
|
|
|
|
} // namespace
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestDiagnosticsPass() {
|
|
PassRegistration<TestDiagnosticFilterPass>{};
|
|
}
|
|
} // namespace test
|
|
} // namespace mlir
|