Matt Arsenault dd094b2647 NewPM/AMDGPU: Port AMDGPUPerfHintAnalysis to new pass manager (#102645) ...

This was much more difficult than I anticipated. The pass is
not in a good state, with poor test coverage. The legacy PM
does seem to be relying on maintaining the map state between
different SCCs, which seems bad. The pass is going out of its
way to avoid putting the attributes it introduces onto non-callee
functions. If it just added them, we could use them directly
instead of relying on the map, I would think.

The NewPM path uses a ModulePass; I'm not sure if we should be
using CGSCC here but there seems to be some missing infrastructure
to support backend defined ones.

2024-08-11 15:11:10 +04:00

15 KiB

Raw Blame History

View Raw