76a21502fd
ClangCheckerRegistry is a very non-obvious, poorly documented, weird concept. It derives from CheckerRegistry, and is placed in lib/StaticAnalyzer/Frontend, whereas it's base is located in lib/StaticAnalyzer/Core. It was, from what I can imagine, used to circumvent the problem that the registry functions of the checkers are located in the clangStaticAnalyzerCheckers library, but that library depends on clangStaticAnalyzerCore. However, clangStaticAnalyzerFrontend depends on both of those libraries. One can make the observation however, that CheckerRegistry has no place in Core, it isn't used there at all! The only place where it is used is Frontend, which is where it ultimately belongs. This move implies that since include/clang/StaticAnalyzer/Checkers/ClangCheckers.h only contained a single function: class CheckerRegistry; void registerBuiltinCheckers(CheckerRegistry ®istry); it had to re purposed, as CheckerRegistry is no longer available to clangStaticAnalyzerCheckers. It was renamed to BuiltinCheckerRegistration.h, which actually describes it a lot better -- it does not contain the registration functions for checkers, but only those generated by the tblgen files. Differential Revision: https://reviews.llvm.org/D54436 llvm-svn: 349275
94 lines
3.0 KiB
C++
94 lines
3.0 KiB
C++
//==- CheckSizeofPointer.cpp - Check for sizeof on pointers ------*- C++ -*-==//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines a check for unintended use of sizeof() on pointer
|
|
// expressions.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/AST/StmtVisitor.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class WalkAST : public StmtVisitor<WalkAST> {
|
|
BugReporter &BR;
|
|
const CheckerBase *Checker;
|
|
AnalysisDeclContext* AC;
|
|
|
|
public:
|
|
WalkAST(BugReporter &br, const CheckerBase *checker, AnalysisDeclContext *ac)
|
|
: BR(br), Checker(checker), AC(ac) {}
|
|
void VisitUnaryExprOrTypeTraitExpr(UnaryExprOrTypeTraitExpr *E);
|
|
void VisitStmt(Stmt *S) { VisitChildren(S); }
|
|
void VisitChildren(Stmt *S);
|
|
};
|
|
}
|
|
|
|
void WalkAST::VisitChildren(Stmt *S) {
|
|
for (Stmt *Child : S->children())
|
|
if (Child)
|
|
Visit(Child);
|
|
}
|
|
|
|
// CWE-467: Use of sizeof() on a Pointer Type
|
|
void WalkAST::VisitUnaryExprOrTypeTraitExpr(UnaryExprOrTypeTraitExpr *E) {
|
|
if (E->getKind() != UETT_SizeOf)
|
|
return;
|
|
|
|
// If an explicit type is used in the code, usually the coder knows what they are
|
|
// doing.
|
|
if (E->isArgumentType())
|
|
return;
|
|
|
|
QualType T = E->getTypeOfArgument();
|
|
if (T->isPointerType()) {
|
|
|
|
// Many false positives have the form 'sizeof *p'. This is reasonable
|
|
// because people know what they are doing when they intentionally
|
|
// dereference the pointer.
|
|
Expr *ArgEx = E->getArgumentExpr();
|
|
if (!isa<DeclRefExpr>(ArgEx->IgnoreParens()))
|
|
return;
|
|
|
|
PathDiagnosticLocation ELoc =
|
|
PathDiagnosticLocation::createBegin(E, BR.getSourceManager(), AC);
|
|
BR.EmitBasicReport(AC->getDecl(), Checker,
|
|
"Potential unintended use of sizeof() on pointer type",
|
|
categories::LogicError,
|
|
"The code calls sizeof() on a pointer type. "
|
|
"This can produce an unexpected result.",
|
|
ELoc, ArgEx->getSourceRange());
|
|
}
|
|
}
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// SizeofPointerChecker
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
class SizeofPointerChecker : public Checker<check::ASTCodeBody> {
|
|
public:
|
|
void checkASTCodeBody(const Decl *D, AnalysisManager& mgr,
|
|
BugReporter &BR) const {
|
|
WalkAST walker(BR, this, mgr.getAnalysisDeclContext(D));
|
|
walker.Visit(D->getBody());
|
|
}
|
|
};
|
|
}
|
|
|
|
void ento::registerSizeofPointerChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<SizeofPointerChecker>();
|
|
}
|