5b354d204d
`image dump symtab` seems to output the symbols in whatever order they appear in the DenseMap that is used to filter out symbols with non-unique addresses. As DenseMap is a hash map this order can change at any time so the output of this command is pretty unstable. This also causes the `Breakpad/symtab.test` to fail with enabled reverse iteration (which reverses the DenseMap order to find issues like this). This patch makes the DenseMap a std::vector and uses a separate DenseSet to do the address filtering. The output order is now dependent on the order in which the symbols are read (which should be deterministic). It might also avoid a bit of work as all the work for creating the Symbol constructor parameters is only done when we can actually emplace a new Symbol. Reviewed By: labath Differential Revision: https://reviews.llvm.org/D87036
26 lines
1.5 KiB
Plaintext
26 lines
1.5 KiB
Plaintext
# RUN: yaml2obj %S/Inputs/basic-elf.yaml -o %T/symtab.out
|
|
# RUN: %lldb %T/symtab.out -o "target symbols add -s symtab.out %S/Inputs/symtab.syms" \
|
|
# RUN: -s %s | FileCheck %s
|
|
|
|
# CHECK-LABEL: (lldb) image dump symtab symtab.out
|
|
# CHECK: Symtab, file = {{.*}}symtab.out, num_symbols = 5:
|
|
# CHECK: Index UserID DSX Type File Address/Value Load Address Size Flags Name
|
|
# CHECK: [ 0] 0 SX Code 0x0000000000400000 0x00000000000000b0 0x00000000 ___lldb_unnamed_symbol{{[0-9]*}}$$symtab.out
|
|
# CHECK: [ 1] 0 X Code 0x00000000004000b0 0x000000000000000c 0x00000000 f1_func
|
|
# CHECK: [ 2] 0 X Code 0x00000000004000a0 0x000000000000000d 0x00000000 func_only
|
|
# CHECK: [ 3] 0 X Code 0x00000000004000c0 0x0000000000000010 0x00000000 f2
|
|
# CHECK: [ 4] 0 X Code 0x00000000004000d0 0x0000000000000022 0x00000000 _start
|
|
|
|
# CHECK-LABEL: (lldb) image lookup -a 0x4000b0 -v
|
|
# CHECK: Address: symtab.out[0x00000000004000b0] (symtab.out.PT_LOAD[0]..text2 + 0)
|
|
# CHECK: Symbol: id = {0x00000000}, range = [0x00000000004000b0-0x00000000004000bc), name="f1_func"
|
|
|
|
# CHECK-LABEL: (lldb) image lookup -n f2 -v
|
|
# CHECK: Address: symtab.out[0x00000000004000c0] (symtab.out.PT_LOAD[0]..text2 + 16)
|
|
# CHECK: Symbol: id = {0x00000000}, range = [0x00000000004000c0-0x00000000004000d0), name="f2"
|
|
|
|
image dump symtab symtab.out
|
|
image lookup -a 0x4000b0 -v
|
|
image lookup -n f2 -v
|
|
exit
|